https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Packaging |Installation and upgrade | |(command-line installer) Depends on| |13937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|log4perl.conf.in missing |log4perl-site.conf.in |entries for the z39.50 |missing entries for the |server |z39.50 server -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 101018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101018&action=edit Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101018|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 101020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101020&action=edit Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101020|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101894&action=edit Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Joy, if you would pick this one for 19.11.x, please wait until bug 24905 can be pushed along with this one. Together, not separate :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 [Bug 15253] Add Koha::Logger based logging for SIP2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25510 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #6)

Works well in testing.. clear code.. going for a straight QA on this one.

I'm so intrigued by this because I don't see how that code in debian/koha-common.postinst could have ever worked correctly :S. -- You are receiving this mail because: You are watching all bug changes.