[Bug 13687] New: ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Bug ID: 13687 Summary: ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35777&action=edit Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35777|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36014&action=edit Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36014|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36336&action=edit [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. No regressions found, improves the ILS-DI HoldItem response. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The patch doesn't apply. Please consider taking a look at bug 5786 on rebasing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 38398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38398&action=edit [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #7 from Kyle M Hall <kyle.m.hall@gmail.com> --- *** Bug 10314 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org