[Bug 21792] New: Switch two-column templates to Bootstrap grid: Serials part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Bug ID: 21792 Summary: Switch two-column templates to Bootstrap grid: Serials part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 20654 These serials templates should be revised as part of the move to Bootstrap grids: - modules/serials/subscription-add.tt has some CSS which refers to obsolete YUI markup. - modules/serials/subscription-batchedit.tt needs to be converted. - modules/serials/subscription-renew.tt contains some stray YUI markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82107&action=edit Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3 This patch modifies several serials templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Serials. - Add or edit a new subscription. The "create an item..." and "do not create an item..." labels should look correct. - Search for subscriptions - Select two or more subscriptions to batch edit. - The subscription batch edit page should look correct and adjust well to various browser widths. - View a subscription and click the "Renew" button. The subscription renewal pop-up window should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82107|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 83593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83593&action=edit Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3 This patch modifies several serials templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Serials. - Add or edit a new subscription. The "create an item..." and "do not create an item..." labels should look correct. - Search for subscriptions - Select two or more subscriptions to batch edit. - The subscription batch edit page should look correct and adjust well to various browser widths. - View a subscription and click the "Renew" button. The subscription renewal pop-up window should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83593|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83605&action=edit Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3 This patch modifies several serials templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Serials. - Add or edit a new subscription. The "create an item..." and "do not create an item..." labels should look correct. - Search for subscriptions - Select two or more subscriptions to batch edit. - The subscription batch edit page should look correct and adjust well to various browser widths. - View a subscription and click the "Renew" button. The subscription renewal pop-up window should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21792 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org