[Bug 32212] New: Add separate Bootstrap 4 node module for the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Bug ID: 32212 Summary: Add separate Bootstrap 4 node module for the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32030 Blocks: 25267 Bug 32030 - Electronic resource management - updated the Bootstrap node module to 5.2.x, but the OPAC still needs a copy of Bootstrap 4. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 [Bug 25267] OPAC browse shelf feature is not responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143924&action=edit Bug 32212: Add separate Bootstrap 4 node module for the OPAC This patch updates package.json so that Bootstrap 4 will be installed alongside Bootstrap 5. The addition of ERM changed the installed version of Bootstrap to 5.2.x but the OPAC still requires 4.x. To test, apply the patch and run 'yarn install.' After packages install, run 'yarn build --view opac' The build process should complete correctly and the OPAC should look the same as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143924|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143925&action=edit Bug 32212: Add separate Bootstrap 4 node module for the OPAC This patch updates package.json so that Bootstrap 4 will be installed alongside Bootstrap 5. The addition of ERM changed the installed version of Bootstrap to 5.2.x but the OPAC still requires 4.x. To test, apply the patch and run 'yarn install.' After packages install, run 'yarn build --view opac' The build process should complete correctly and the OPAC should look the same as before. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: - I had a brief roam around the OPAC, everything looked OK and I didn't notice anything that was different. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Anything particular to look for in this one? Is something clearly broken without it which is fixed with it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #4)
Anything particular to look for in this one?
Is something clearly broken without it which is fixed with it?
See bug 25267 - without this, you can't rebuild the CSS for the OPAC. So, before applying the patch: 1. yarn install 2. yarn build --view opac 3. Result - you get an error: yarn build --view opac yarn run v1.22.19 $ node_modules/.bin/gulp build --view opac [22:33:59] Using gulpfile /kohadevbox/koha/gulpfile.js [22:33:59] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/custom-forms. on line 52 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@import "../../../../../node_modules/bootstrap/scss/custom-forms";
^ [22:33:59] Finished 'build' after 91 ms Done in 2.42s. 4. Apply the patch. 5. Repeat steps 1 and 2. 6. Result - OPAC CSS is rebuilt successfully without any errors. Also, see the discussion on IRC http://irc.koha-community.org/koha/2022-11-15#i_2462075 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am sorry, this is a mistake, we should not have the version bump. We are finally not using bootstrap 5 for ERM, see commit "Bug 32030: ERM - Remove BootstrapVue3" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We could go with your patch or remove "bootstrap-vue-3": "^0.1.7", and adjust the bootstrap version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I think removing Bootstrap 5 is the right thing to do, if we don't need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143925|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143981&action=edit Bug 32212: (bug 32030 follow-up) Restore bootstrap 4 During the development of the eRM module I've tried to use bootstrap 5 (and vue-bootstrap), but I didn't manage to make it work without modifying the version used in Koha. This change is actually not needed and we can keep version 4. See commit 8c32f186d5a62e742621c35cfacff5b22bb42b71 Bug 32030: ERM - Remove BootstrapVue3 Test plan: % yarn install % git diff you should notice the version change in yarn.lock -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143981|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 143995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143995&action=edit Bug 32212: (bug 32030 follow-up) Restore bootstrap 4 During the development of the eRM module I've tried to use bootstrap 5 (and vue-bootstrap), but I didn't manage to make it work without modifying the version used in Koha. This change is actually not needed and we can keep version 4. See commit 8c32f186d5a62e742621c35cfacff5b22bb42b71 Bug 32030: ERM - Remove BootstrapVue3 Test plan: % yarn install % git diff you should notice the version change in yarn.lock Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #11 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Can now rebuild OPAC CSS. 2. There are two warnings when running yarn install - not sure whether these need to be addressed or not: yarn install yarn install v1.22.19 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning " > bootstrap@4.6.2" has unmet peer dependency "jquery@1.9.1 - 3". warning " > bootstrap@4.6.2" has unmet peer dependency "popper.js@^1.16.1". [4/4] Building fresh packages... success Saved lockfile. Done in 6.43s. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143995|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144019&action=edit Bug 32212: (bug 32030 follow-up) Restore bootstrap 4 During the development of the eRM module I've tried to use bootstrap 5 (and vue-bootstrap), but I didn't manage to make it work without modifying the version used in Koha. This change is actually not needed and we can keep version 4. See commit 8c32f186d5a62e742621c35cfacff5b22bb42b71 Bug 32030: ERM - Remove BootstrapVue3 Test plan: % yarn install % git diff you should notice the version change in yarn.lock Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org