[Bug 23194] New: Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Bug ID: 23194 Summary: Public notes items in the OPAC should allow for HTML tags Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- As with similar bugs, 22938, 22702, 22501, the HTML tags are broken in the newest version of 18.11. If an item has a URL in the public notes subfield, this should be allowed to have HTML tags. Currently, this is not displaying correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Would like to see this fixed ASAP. We have MANY item records with HTML links in the public notes field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90987&action=edit Bug 23194: Allow HTML in item public notes to be processed on OPAC details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90988&action=edit Bug 23194: Fix other occurences Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? The items lost report also included the note as a title element on title and barcode links, I removed this as the note displays in that table To test: 1 - Add a link to publicnotes for an item <a href="www.google.com">Cats!</a> 2 - View opac details, confirm the note is a link 3 - Same for staff side 4 - Add item to a course reserve UseCourseReserves preference must be set to 'Use' From the course reserves module you will need to add a course (and possibly a department first) Adding should be intuitive 5 - Confirm note is a link in course details on staff and opac 6 - Perform a batch checkout, confirm the itemnote shows as a link You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories Then a link should be available from checkout for a patron in that category 7 - Mark the item as lost 8 - Go to Reports->Items lost 9 - Confirm the note is a URL and that title and barcode links don't show the note 10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90987|0 |1 is obsolete| | Attachment #90988|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 91014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91014&action=edit [SIGNED-OFF] Bug 23194: Allow HTML in item public notes to be processed on OPAC details Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 91015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91015&action=edit [SIGNED-OFF] Bug 23194: Fix other occurences Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? The items lost report also included the note as a title element on title and barcode links, I removed this as the note displays in that table To test: 1 - Add a link to publicnotes for an item <a href="www.google.com">Cats!</a> 2 - View opac details, confirm the note is a link 3 - Same for staff side 4 - Add item to a course reserve UseCourseReserves preference must be set to 'Use' From the course reserves module you will need to add a course (and possibly a department first) Adding should be intuitive 5 - Confirm note is a link in course details on staff and opac 6 - Perform a batch checkout, confirm the itemnote shows as a link You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories Then a link should be available from checkout for a patron in that category 7 - Mark the item as lost 8 - Go to Reports->Items lost 9 - Confirm the note is a URL and that title and barcode links don't show the note 10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #6 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91370&action=edit Bug 23194: Allow HTML in item public notes to be processed on OPAC details Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #7 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91371&action=edit Bug 23194: Fix other occurences Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? The items lost report also included the note as a title element on title and barcode links, I removed this as the note displays in that table To test: 1 - Add a link to publicnotes for an item <a href="www.google.com">Cats!</a> 2 - View opac details, confirm the note is a link 3 - Same for staff side 4 - Add item to a course reserve UseCourseReserves preference must be set to 'Use' From the course reserves module you will need to add a course (and possibly a department first) Adding should be intuitive 5 - Confirm note is a link in course details on staff and opac 6 - Perform a batch checkout, confirm the itemnote shows as a link You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories Then a link should be available from checkout for a patron in that category 7 - Mark the item as lost 8 - Go to Reports->Items lost 9 - Confirm the note is a URL and that title and barcode links don't show the note 10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #91014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91370|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91389&action=edit Bug 23194: Allow HTML in item public notes to be processed on OPAC details Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91371|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91390&action=edit Bug 23194: Fix other occurences Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? The items lost report also included the note as a title element on title and barcode links, I removed this as the note displays in that table To test: 1 - Add a link to publicnotes for an item <a href="www.google.com">Cats!</a> 2 - View opac details, confirm the note is a link 3 - Same for staff side 4 - Add item to a course reserve UseCourseReserves preference must be set to 'Use' From the course reserves module you will need to add a course (and possibly a department first) Adding should be intuitive 5 - Confirm note is a link in course details on staff and opac 6 - Perform a batch checkout, confirm the itemnote shows as a link You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories Then a link should be available from checkout for a patron in that category 7 - Mark the item as lost 8 - Go to Reports->Items lost 9 - Confirm the note is a URL and that title and barcode links don't show the note 10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Since 18.11, item.itemnotes release notes| |content is escaped so any | |HTML tag would appear | |broken. It is now allowed | |again, hyperlinks for | |example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I rise to major because of impact on OPAC display. Hope it will be released soon in 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23409 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrs.markx86@gmail.com --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22469 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- This works great! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #16 from Christopher Brannon <cbrannon@cdalibrary.org> --- Is there a version of this that works for the staff interface? Links are just turned into static text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Christopher Brannon from comment #16)
Is there a version of this that works for the staff interface? Links are just turned into static text.
Hi Christopher, in my testing it works in staff apart from the table on the 'add item' screen. Can you please recheck and file a new bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca --- Comment #18 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Christopher Brannon from comment #16)
Is there a version of this that works for the staff interface? Links are just turned into static text.
Hi Christopher, Did you file a new bug for that? I see static text in checkout table (circ/circulation.pl) Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org