[Bug 19994] New: use Modern::Perl in Authorities perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Bug ID: 19994 Summary: use Modern::Perl in Authorities perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Grace <gracesmythh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 --- Comment #1 from Grace <gracesmythh@gmail.com> --- Created attachment 70661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70661&action=edit Bug 19994: use Modern::Perl in Authorities perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Grace <gracesmythh@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracesmythh@gmail.com Attachment #70661|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 --- Comment #2 from Grace <gracesmythh@gmail.com> --- Created attachment 70675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70675&action=edit Bug 19994: use Modern::Perl in Authorities perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #3 from Jon Knight <J.P.Knight@lboro.ac.uk> --- The files: authorities/detail-biblio-search.pl authorities/export.pl still appear to have a use strict in them after applying the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Patch needs rebasing: Applying: Bug 19994: use Modern::Perl in Authorities perl scripts Using index info to reconstruct a base tree... M authorities/auth_finder.pl M authorities/authorities-home.pl A authorities/authorities-list.pl M authorities/authorities.pl M authorities/blinddetail-biblio-search.pl M authorities/detail.pl M authorities/merge.pl Falling back to patching base and 3-way merge... Auto-merging authorities/merge.pl Auto-merging authorities/detail.pl Auto-merging authorities/blinddetail-biblio-search.pl Auto-merging authorities/authorities.pl CONFLICT (modify/delete): authorities/authorities-list.pl deleted in HEAD and modified in Bug 19994: use Modern::Perl in Authorities perl scripts. Version Bug 19994: use Modern::Perl in Authorities perl scripts of authorities/authorities-list.pl left in tree. Auto-merging authorities/authorities-home.pl Auto-merging authorities/auth_finder.pl Failed to merge in the changes. Patch failed at 0001 Bug 19994: use Modern::Perl in Authorities perl scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70675|0 |1 is obsolete| | --- Comment #5 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84109&action=edit Bug 19994: Used Modern::Perl in Authorities perl scripts Test plan: 1. Review code of the following files and confirm that 'use Modern::Perl;' is used in place of 'use strict; use warnings;' auth_finder.pl authorities-home.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jasmineamohia.student@wegc. | |school.nz Assignee|koha-bugs@lists.koha-commun |jasmineamohia.student@wegc. |ity.org |school.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84109|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 84178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84178&action=edit Bug 19994: Used Modern::Perl in Authorities perl scripts Test plan: 1. Review code of the following files and confirm that 'use Modern::Perl;' is used in place of 'use strict; use warnings;' auth_finder.pl authorities-home.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84178|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84255&action=edit Bug 19994: Used Modern::Perl in Authorities perl scripts Test plan: 1. Review code of the following files and confirm that 'use Modern::Perl;' is used in place of 'use strict; use warnings;' auth_finder.pl authorities-home.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Trivial, I dont push to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org