[Bug 26145] New: Add the ability to attach a cover image at item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Bug ID: 26145 Summary: Add the ability to attach a cover image at item level Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We can attach one (or more) cover image to bibliographic records, but it would be good in some cases to have the cover image attach to the item. It can be handy for subscription for instance, where we could imagine having the cover image of each serial number displayed on the bibliographic record detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108366&action=edit Bug 26145: DB changes - Add biblioimages.imagenumber Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108367&action=edit Bug 26145: Add the ability to upload a cover image per item This patchset adds the ability to attach cover images at item level. This commit message will explain the different patches that are following. The main idea is to have cover images for a given item. This is useful for a bibliographic record linked with a subscription. Each item could have the cover image for the serial numbers. In this first patch there is a limitation to allow only 1 cover per item, but a later patch will remove it. That way we will take advantage of the recent work done to display nicely cover images (bug 25031), and reuse it in this development (staff interface only). In order to use a flexible and robust code, the legacy C4 code (C4::Images) has been moved to Koha::CoverImages. Also the DB table biblioimages has been renamed cover_images. Test plan (for the whole patch set): 0. Turn off AllowMultipleCovers 1. Create a new bibliographic record and items 2. Attach a cover image to the bibliographic record 3. In the item list of the bibliographic detail page, you will notice a new "Upload image" action. Select it 4. Select an image => Notice the new column in the item table 5. Upload another image => You cannot upload 2 images, you are going to replace the existing one 6. Turn on AllowMultipleCovers 7. Attach another image to the image => Notice the 2 images are displayed nicely, with navigation controls 8. Confirm you can view an image if you click on it and you can delete it 9. Test the OPAC view now => Cover image for items are displayed in the table, there is no navigation controls here however. Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108368&action=edit Bug 26145: Display the cover image at the OPAC Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108369&action=edit Bug 26145: Refactoring - Add tests Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108370&action=edit Bug 26145: Refactoring - Rename table biblioimages to cover_images Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108371&action=edit Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108372&action=edit Bug 26145: DBIC schema changes Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108373&action=edit Bug 26145: Allow multi covers per item In this patch we remove the limitation of 1 cover image per item Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108374&action=edit Bug 26145: Compiled CSS Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108372|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108475&action=edit Bug 26145: DBIC schema changes Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Overall this works really well. I see one small markup error: <i class="fa fa-upload">Upload image</i> Should be: <i class="fa fa-upload"></i> Upload image I notice on the detail page in the staff interface it's not possible to use the column visibility menu to hide the cover image column. I'm concerned about the size of the item cover images in the OPAC. I think they should be constrained to something smaller. I think between 75 and 100 pixels would be good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #11)
Overall this works really well. I see one small markup error:
<i class="fa fa-upload">Upload image</i>
Should be:
<i class="fa fa-upload"></i> Upload image
Will do
I notice on the detail page in the staff interface it's not possible to use the column visibility menu to hide the cover image column.
I forgot than, good catch!
I'm concerned about the size of the item cover images in the OPAC. I think they should be constrained to something smaller. I think between 75 and 100 pixels would be good.
It's the size of the thumbnail, do you mean we should limit the thumbnail size when we display it? Why only OPAC, because staff has the slider? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
I forgot than, good catch! I forgot that, good catch!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108517&action=edit Bug 26145: Fix image tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108518&action=edit Bug 26145: Hide 'Upload image' if no CoverImage pref is set If LocalCoverImages AND OPACLocalCoverImages are disabled, we should not let the ability to upload an image for the items. We should also hide the column "cover image" in the tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108519&action=edit Bug 26145: Add the "Cover image" column to the table settings The new column can now be hidden by the table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 C. Bastian <clemens.bastian@elementsystems.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.bastian@elementsyst | |ems.de --- Comment #17 from C. Bastian <clemens.bastian@elementsystems.de> --- My tests resulted in the following two failed scenarios: 1) Description of the test case 1. Turn "AllowMultipleCovers" on Allow, LocalCoverImages "Display", OPACLocalCoverImages "Display" 2. Create bib record ("record 1") 3. Attach one (or more, does not matter) image to "record 1" 4. Create item ("item 1") 5. Attach one (or more, does not matter) to the "item 1" 6. Click on the image of "item 1" and delete it (or any if multiple images were added) 7.You will now see the image(s) which were added to "record 1" not images which were added to "item 1". This is a confusing in my opinion, I would expect to see the remaining images of "item 1" 2) Similar to 1) 1. Turn "AllowMultipleCovers" on Allow, LocalCoverImages "Display", OPACLocalCoverImages "Display" 2. Create bib record ("record 1") 3. Create item ("item 1") 4. Attach one (or more, does not matter) to the "item 1" 5. Click on the image of "item 1" and delete it (or any if multiple images were added) 6. Click on the image of "item 1" (as if you like to remove it) 7. Click on "Upload an image file" below the shown image of "item 1" 8. When you now upload an image here it will be inserted at "record 1" not on "item 1" as how I would expect it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108366|0 |1 is obsolete| | Attachment #108367|0 |1 is obsolete| | Attachment #108368|0 |1 is obsolete| | Attachment #108369|0 |1 is obsolete| | Attachment #108370|0 |1 is obsolete| | Attachment #108371|0 |1 is obsolete| | Attachment #108373|0 |1 is obsolete| | Attachment #108374|0 |1 is obsolete| | Attachment #108475|0 |1 is obsolete| | Attachment #108517|0 |1 is obsolete| | Attachment #108518|0 |1 is obsolete| | Attachment #108519|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108837&action=edit Bug 26145: DB changes - Add biblioimages.imagenumber Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108838&action=edit Bug 26145: Add the ability to upload a cover image per item This patchset adds the ability to attach cover images at item level. This commit message will explain the different patches that are following. The main idea is to have cover images for a given item. This is useful for a bibliographic record linked with a subscription. Each item could have the cover image for the serial numbers. In this first patch there is a limitation to allow only 1 cover per item, but a later patch will remove it. That way we will take advantage of the recent work done to display nicely cover images (bug 25031), and reuse it in this development (staff interface only). In order to use a flexible and robust code, the legacy C4 code (C4::Images) has been moved to Koha::CoverImages. Also the DB table biblioimages has been renamed cover_images. Test plan (for the whole patch set): 0. Turn off AllowMultipleCovers 1. Create a new bibliographic record and items 2. Attach a cover image to the bibliographic record 3. In the item list of the bibliographic detail page, you will notice a new "Upload image" action. Select it 4. Select an image => Notice the new column in the item table 5. Upload another image => You cannot upload 2 images, you are going to replace the existing one 6. Turn on AllowMultipleCovers 7. Attach another image to the image => Notice the 2 images are displayed nicely, with navigation controls 8. Confirm you can view an image if you click on it and you can delete it 9. Test the OPAC view now => Cover image for items are displayed in the table, there is no navigation controls here however. Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108839&action=edit Bug 26145: Display the cover image at the OPAC Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108840&action=edit Bug 26145: Refactoring - Add tests Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108841&action=edit Bug 26145: Refactoring - Rename table biblioimages to cover_images Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108842&action=edit Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108843&action=edit Bug 26145: Allow multi covers per item In this patch we remove the limitation of 1 cover image per item Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108844&action=edit Bug 26145: Compiled CSS Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108845&action=edit Bug 26145: DBIC schema changes Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108846&action=edit Bug 26145: Fix image tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108847&action=edit Bug 26145: Hide 'Upload image' if no CoverImage pref is set If LocalCoverImages AND OPACLocalCoverImages are disabled, we should not let the ability to upload an image for the items. We should also hide the column "cover image" in the tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108848&action=edit Bug 26145: Add the "Cover image" column to the table settings The new column can now be hidden by the table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108849&action=edit Bug 26145: Correctly preserver itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108849|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108850&action=edit Bug 26145: Correctly preserve itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Clemens Bastian from comment #17) Thanks for testing! The last patch will fix the issues you found. The whole patch set has been rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109225&action=edit Bug 26145: Correctly preserve itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109226&action=edit Bug 26145: Use Koha::Logger and display the full stacktrace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110342&action=edit Bug 26145: DB changes - Add biblioimages.imagenumber Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110343&action=edit Bug 26145: Add the ability to upload a cover image per item This patchset adds the ability to attach cover images at item level. This commit message will explain the different patches that are following. The main idea is to have cover images for a given item. This is useful for a bibliographic record linked with a subscription. Each item could have the cover image for the serial numbers. In this first patch there is a limitation to allow only 1 cover per item, but a later patch will remove it. That way we will take advantage of the recent work done to display nicely cover images (bug 25031), and reuse it in this development (staff interface only). In order to use a flexible and robust code, the legacy C4 code (C4::Images) has been moved to Koha::CoverImages. Also the DB table biblioimages has been renamed cover_images. Test plan (for the whole patch set): 0. Turn off AllowMultipleCovers 1. Create a new bibliographic record and items 2. Attach a cover image to the bibliographic record 3. In the item list of the bibliographic detail page, you will notice a new "Upload image" action. Select it 4. Select an image => Notice the new column in the item table 5. Upload another image => You cannot upload 2 images, you are going to replace the existing one 6. Turn on AllowMultipleCovers 7. Attach another image to the image => Notice the 2 images are displayed nicely, with navigation controls 8. Confirm you can view an image if you click on it and you can delete it 9. Test the OPAC view now => Cover image for items are displayed in the table, there is no navigation controls here however. Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110344&action=edit Bug 26145: Display the cover image at the OPAC Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110345&action=edit Bug 26145: Refactoring - Add tests Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110346&action=edit Bug 26145: Refactoring - Rename table biblioimages to cover_images Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110347&action=edit Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110348&action=edit Bug 26145: Allow multi covers per item In this patch we remove the limitation of 1 cover image per item Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110349&action=edit Bug 26145: Fix image tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110350&action=edit Bug 26145: Hide 'Upload image' if no CoverImage pref is set If LocalCoverImages AND OPACLocalCoverImages are disabled, we should not let the ability to upload an image for the items. We should also hide the column "cover image" in the tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110351&action=edit Bug 26145: Add the "Cover image" column to the table settings The new column can now be hidden by the table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110352&action=edit Bug 26145: Correctly preserve itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110353&action=edit Bug 26145: Compiled CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110354&action=edit Bug 26145: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is ready for testing again. Patches have been rebased against master (several conflicts caused by bug 20168) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110344|0 |1 is obsolete| | --- Comment #49 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110675&action=edit Bug 26145: Display the cover image at the OPAC Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110345|0 |1 is obsolete| | --- Comment #50 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110676&action=edit Bug 26145: Refactoring - Add tests Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110346|0 |1 is obsolete| | --- Comment #51 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110677&action=edit Bug 26145: Refactoring - Rename table biblioimages to cover_images Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110347|0 |1 is obsolete| | --- Comment #52 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110678&action=edit Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110348|0 |1 is obsolete| | --- Comment #53 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110679&action=edit Bug 26145: Allow multi covers per item In this patch we remove the limitation of 1 cover image per item Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110349|0 |1 is obsolete| | --- Comment #54 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110680&action=edit Bug 26145: Fix image tag Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110350|0 |1 is obsolete| | --- Comment #55 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110681&action=edit Bug 26145: Hide 'Upload image' if no CoverImage pref is set If LocalCoverImages AND OPACLocalCoverImages are disabled, we should not let the ability to upload an image for the items. We should also hide the column "cover image" in the tables Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110351|0 |1 is obsolete| | --- Comment #56 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110682&action=edit Bug 26145: Add the "Cover image" column to the table settings The new column can now be hidden by the table settings Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110352|0 |1 is obsolete| | --- Comment #57 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110683&action=edit Bug 26145: Correctly preserve itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110353|0 |1 is obsolete| | --- Comment #58 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110684&action=edit Bug 26145: Compiled CSS Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110354|0 |1 is obsolete| | --- Comment #59 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110685&action=edit Bug 26145: DBIC schema changes Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov --- Comment #60 from Heather <heather_hernandez@nps.gov> --- Going through the steps of the test plan, everything went exactly as it should! Yea! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Fixed some missing filters - posting follow-up. 2) Hm, the 2 separate updatedatabase statements are a bit confusing. Please merge them. 3) New column is not added to the column configuration for the items table in the OPAC. I've tried to fix it, but just adding it to the .yml didn't have the intended effect. Can you please have a look? The fail is for 3, overall this works well already :) Note: I think it would have been nice to have this split into several bugs, starting with the rewrite of C4::Images into the Koha namespace for the existing functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110800&action=edit Bug 26145: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110342|0 |1 is obsolete| | Attachment #110343|0 |1 is obsolete| | Attachment #110675|0 |1 is obsolete| | Attachment #110676|0 |1 is obsolete| | Attachment #110677|0 |1 is obsolete| | Attachment #110678|0 |1 is obsolete| | Attachment #110679|0 |1 is obsolete| | Attachment #110680|0 |1 is obsolete| | Attachment #110681|0 |1 is obsolete| | Attachment #110682|0 |1 is obsolete| | Attachment #110683|0 |1 is obsolete| | Attachment #110684|0 |1 is obsolete| | Attachment #110685|0 |1 is obsolete| | Attachment #110800|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110861&action=edit Bug 26145: DB changes - Add biblioimages.imagenumber Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110862&action=edit Bug 26145: Add the ability to upload a cover image per item This patchset adds the ability to attach cover images at item level. This commit message will explain the different patches that are following. The main idea is to have cover images for a given item. This is useful for a bibliographic record linked with a subscription. Each item could have the cover image for the serial numbers. In this first patch there is a limitation to allow only 1 cover per item, but a later patch will remove it. That way we will take advantage of the recent work done to display nicely cover images (bug 25031), and reuse it in this development (staff interface only). In order to use a flexible and robust code, the legacy C4 code (C4::Images) has been moved to Koha::CoverImages. Also the DB table biblioimages has been renamed cover_images. Test plan (for the whole patch set): 0. Turn off AllowMultipleCovers 1. Create a new bibliographic record and items 2. Attach a cover image to the bibliographic record 3. In the item list of the bibliographic detail page, you will notice a new "Upload image" action. Select it 4. Select an image => Notice the new column in the item table 5. Upload another image => You cannot upload 2 images, you are going to replace the existing one 6. Turn on AllowMultipleCovers 7. Attach another image to the image => Notice the 2 images are displayed nicely, with navigation controls 8. Confirm you can view an image if you click on it and you can delete it 9. Test the OPAC view now => Cover image for items are displayed in the table, there is no navigation controls here however. Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110863&action=edit Bug 26145: Display the cover image at the OPAC Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110864&action=edit Bug 26145: Refactoring - Add tests Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110865&action=edit Bug 26145: Refactoring - Rename table biblioimages to cover_images Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110866&action=edit Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110867&action=edit Bug 26145: Allow multi covers per item In this patch we remove the limitation of 1 cover image per item Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110868&action=edit Bug 26145: Fix image tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110869&action=edit Bug 26145: Hide 'Upload image' if no CoverImage pref is set If LocalCoverImages AND OPACLocalCoverImages are disabled, we should not let the ability to upload an image for the items. We should also hide the column "cover image" in the tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110870&action=edit Bug 26145: Add the "Cover image" column to the table settings The new column can now be hidden by the table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110871&action=edit Bug 26145: Correctly preserve itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110872&action=edit Bug 26145: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110873&action=edit Bug 26145: Compiled CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110874&action=edit Bug 26145: Add the new column to the column settings yml file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110875&action=edit Bug 26145: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #61)
1) Fixed some missing filters - posting follow-up.
Thanks!
2) Hm, the 2 separate updatedatabase statements are a bit confusing. Please merge them.
Ok, I will merge them before pushing them. They are 2 different things, so I wanted to make it clear in the output.
3) New column is not added to the column configuration for the items table in the OPAC. I've tried to fix it, but just adding it to the .yml didn't have the intended effect. Can you please have a look?
Done.
Note: I think it would have been nice to have this split into several bugs, starting with the rewrite of C4::Images into the Koha namespace for the existing functionality.
I took advantage of being in this part of the code to move legacy C4 code to the Koha namespace. I did not plan to do that before writing the first patches (hence it is not done at the beginning of the patch stack). The only thing I could have separated is the "allow multiple covers", but I thought it was good to have it from scratch (as it is the current behaviour for biblio records). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110861|0 |1 is obsolete| | Attachment #110872|0 |1 is obsolete| | Attachment #110873|0 |1 is obsolete| | --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111446&action=edit Bug 26145: DB changes - Add biblioimages.imagenumber Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110862|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111447&action=edit Bug 26145: Add the ability to upload a cover image per item This patchset adds the ability to attach cover images at item level. This commit message will explain the different patches that are following. The main idea is to have cover images for a given item. This is useful for a bibliographic record linked with a subscription. Each item could have the cover image for the serial numbers. In this first patch there is a limitation to allow only 1 cover per item, but a later patch will remove it. That way we will take advantage of the recent work done to display nicely cover images (bug 25031), and reuse it in this development (staff interface only). In order to use a flexible and robust code, the legacy C4 code (C4::Images) has been moved to Koha::CoverImages. Also the DB table biblioimages has been renamed cover_images. Test plan (for the whole patch set): 0. Turn off AllowMultipleCovers 1. Create a new bibliographic record and items 2. Attach a cover image to the bibliographic record 3. In the item list of the bibliographic detail page, you will notice a new "Upload image" action. Select it 4. Select an image => Notice the new column in the item table 5. Upload another image => You cannot upload 2 images, you are going to replace the existing one 6. Turn on AllowMultipleCovers 7. Attach another image to the image => Notice the 2 images are displayed nicely, with navigation controls 8. Confirm you can view an image if you click on it and you can delete it 9. Test the OPAC view now => Cover image for items are displayed in the table, there is no navigation controls here however. Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110863|0 |1 is obsolete| | --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111448&action=edit Bug 26145: Display the cover image at the OPAC Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110864|0 |1 is obsolete| | --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111449&action=edit Bug 26145: Refactoring - Add tests Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110865|0 |1 is obsolete| | --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111450&action=edit Bug 26145: Refactoring - Rename table biblioimages to cover_images Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110866|0 |1 is obsolete| | --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111451&action=edit Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110867|0 |1 is obsolete| | --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111452&action=edit Bug 26145: Allow multi covers per item In this patch we remove the limitation of 1 cover image per item Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110868|0 |1 is obsolete| | --- Comment #86 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111453&action=edit Bug 26145: Fix image tag Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110869|0 |1 is obsolete| | --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111454&action=edit Bug 26145: Hide 'Upload image' if no CoverImage pref is set If LocalCoverImages AND OPACLocalCoverImages are disabled, we should not let the ability to upload an image for the items. We should also hide the column "cover image" in the tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110870|0 |1 is obsolete| | --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111455&action=edit Bug 26145: Add the "Cover image" column to the table settings The new column can now be hidden by the table settings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110871|0 |1 is obsolete| | --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111456&action=edit Bug 26145: Correctly preserve itemnumber value In order to know we are dealing with the cover images of a specific item we need to pass it though the different forms. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110874|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111457&action=edit Bug 26145: Add the new column to the column settings yml file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110875|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111458&action=edit Bug 26145: (QA follow-up) Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had to skip over the compiled CSS and DBIC patches when applying the patch set and ran those locally. One last idea: As we rename a table with a nice name here, we could add another database statement to replace the table name (old to new) in any reports that libraries might have written. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #92)
One last idea: As we rename a table with a nice name here, we could add another database statement to replace the table name (old to new) in any reports that libraries might have written.
We could do that but are you aware of people using this table in reports? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #94)
(In reply to Katrin Fischer from comment #92)
One last idea: As we rename a table with a nice name here, we could add another database statement to replace the table name (old to new) in any reports that libraries might have written.
We could do that but are you aware of people using this table in reports?
I am not sure, could it be used in plugins for cover display? Or someone looking for records without added covers yet. It was not a blocker to me, but it might be an easy one in this case that could make things go smoother. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #96 from Lucas Gass <lucas@bywatersolutions.com> --- nice enhancement but will not be backporting to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #97 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #95)
(In reply to Jonathan Druart from comment #94)
(In reply to Katrin Fischer from comment #92)
One last idea: As we rename a table with a nice name here, we could add another database statement to replace the table name (old to new) in any reports that libraries might have written.
We could do that but are you aware of people using this table in reports?
I am not sure, could it be used in plugins for cover display? Or someone looking for records without added covers yet. It was not a blocker to me, but it might be an easy one in this case that could make things go smoother.
Sorry, I forgot about that. I think I disagreed and that's why I did not answer at the time. And I still don't think it's a good idea. We could replace "biblioimages" with "cover_images" in the reports, but we could might introduce regressions, with bad side-effects. The error "table does not exist" will be trivial to fix for anyone knowing how to write SQL code. However I am inclined to do it if you strongly feel it's now needed (but it's not what you thought apparently). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No, I don't feel strongly and your argument is good too. We can leave that as is I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If LocalCoverImages is release notes| |turned on, it will now be | |possible to attach a local | |cover images for an item. | |It can be especially useful | |for subscriptions. One | |cover image could be attach | |per serial number. | |The | |cover images will be | |displayed on the item list | |on the bibliographic record | |detail page. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|If LocalCoverImages is |If LocalCoverImages is release notes|turned on, it will now be |turned on, it will now be |possible to attach a local |possible to attach a local |cover images for an item. |cover images for an item. |It can be especially useful |It can be especially useful |for subscriptions. One |for subscriptions. One |cover image could be attach |cover image could be attach |per serial number. |per serial number. |The |The |cover images will be |cover images will be |displayed on the item list |displayed on the item list |on the bibliographic record |table on the bibliographic |detail page. |record detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 [Bug 27130] Adding local cover image at item level shows 'File type' section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30792 [Bug 30792] Item cover images don't load in "Other holdings" tab -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org