[Bug 24377] New: Record branch in statistics for auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Bug ID: 24377 Summary: Record branch in statistics for auto-renewal Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org As of 19.05, statistics.branch is null when recording a renewal performed by the auto-renew cron. Prior to 19.05, a branch was recorded (though I'm not clear if that was the branch whose rules were used or the branch from the issues table). It looks like this was changed by bug 22600. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org --- Comment #1 from Ed Veal <eveal@mckinneytexas.org> --- This causes significant statistical differences in circulation numbers post upgrade. I think this is a regression and should be addressed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Daniel Gaghan <daniel.gaghan@pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97438&action=edit Bug 24377: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97439&action=edit Bug 24377: Record passed branch if renewing via cron To test: 1 - Checkout an item with auto renewal set and eligible for auto renew 2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period) 3 - perl misc/cronjobs/automatic_renewals.pl 4 - Check the statistics table, note the branch for renewal is null SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL' 5 - Apply patch 6 - Repeat 1-4 7 - Note the branch is set to the issuing branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97438|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97441&action=edit Bug 24377: Unit test Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97439|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97442&action=edit Bug 24377: Record passed branch if renewing via cron To test: 1 - Checkout an item with auto renewal set and eligible for auto renew 2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period) 3 - perl misc/cronjobs/automatic_renewals.pl 4 - Check the statistics table, note the branch for renewal is null SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL' 5 - Apply patch 6 - Repeat 1-4 7 - Note the branch is set to the issuing branch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97442|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97453&action=edit Bug 24377: Record passed branch if renewing via cron To test: 1 - Checkout an item with auto renewal set and eligible for auto renew 2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period) 3 - perl misc/cronjobs/automatic_renewals.pl 4 - Check the statistics table, note the branch for renewal is null SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL' 5 - Apply patch 6 - Repeat 1-4 7 - Note the branch is set to the issuing branch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ed Veal <eveal@mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Bumping to major, this causes data loss for statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97441|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98167&action=edit Bug 24377: Unit test Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97453|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98168&action=edit Bug 24377: Record passed branch if renewing via cron To test: 1 - Checkout an item with auto renewal set and eligible for auto renew 2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period) 3 - perl misc/cronjobs/automatic_renewals.pl 4 - Check the statistics table, note the branch for renewal is null SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL' 5 - Apply patch 6 - Repeat 1-4 7 - Note the branch is set to the issuing branch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ed Veal <eveal@mckinneytexas.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yikes, that is not a side effect I had imagined.. sorry guys. Thanks for the quick fix Nick.. passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org