[Bug 41136] New: Advanced doesn't search on SRU servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Bug ID: 41136 Summary: Advanced doesn't search on SRU servers Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The advanced editor has a hardcoded use of 'zed' for the type of server, which implies Z39.50 and not SRU. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |andrew@bywatersolutions.com | |, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40841 [Bug 40841] Limit z39.50 targets to specific branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188596&action=edit Bug 41136: Allow advanced editor to search SRU servers This patch makes the advanced editor be able to search on SRU servers also, instead of only Z39.50. To test: 0. On a fresh KTD 1. Enable and open the cataloguing advanced editor 2. Click on 'Advanced >>' on the left column => FAIL: Only non-SRU targets are displayed 3. Apply this patch and reload 4. Repeat 2 => SUCCESS: SRU server displayed! => SUCCESS: No authority server is displayed due to the change i.e. behavior remains unchanged besides SRU support 5. Choose the sample SRU server and make a search => SUCCESS: Things work 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This patch makes the advanced editor be able to search on SRU servers also, instead of only Z39.50. To test: 0. On a fresh KTD 1. Enable and open the cataloguing advanced editor 2. Click on 'Advanced >>' on the left column => FAIL: Only non-SRU targets are displayed 3. Apply this patch and reload 4. Repeat 2 => SUCCESS: SRU server displayed! => SUCCESS: No authority server is displayed due to the change i.e. behavior remains unchanged besides SRU support 5. Choose the sample SRU server and make a search => SUCCESS: Things work 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188607&action=edit Bug 41136: Allow advanced editor to search SRU servers This patch makes the advanced editor be able to search on SRU servers also, instead of only Z39.50. To test: 0. On a fresh KTD 1. Enable and open the cataloguing advanced editor 2. Click on 'Advanced >>' on the left column => FAIL: Only non-SRU targets are displayed 3. Apply this patch and reload 4. Repeat 2 => SUCCESS: SRU server displayed! => SUCCESS: No authority server is displayed due to the change i.e. behavior remains unchanged besides SRU support 5. Choose the sample SRU server and make a search => SUCCESS: Things work 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This patch makes the advanced editor be able to search on SRU servers also, instead of only Z39.50. To test: 0. On a fresh KTD 1. Enable and open the cataloguing advanced editor 2. Click on 'Advanced >>' on the left column => FAIL: Only non-SRU targets are displayed 3. Apply this patch and reload 4. Repeat 2 => SUCCESS: SRU server displayed! => SUCCESS: No authority server is displayed due to the change i.e. behavior remains unchanged besides SRU support 5. Choose the sample SRU server and make a search => SUCCESS: Things work 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188596|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 188608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188608&action=edit Bug 41136: Allow advanced editor to search SRU servers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This patch makes the advanced editor be able to search on SRU servers also, instead of only Z39.50. To test: 0. On a fresh KTD 1. Enable and open the cataloguing advanced editor 2. Click on 'Advanced >>' on the left column => FAIL: Only non-SRU targets are displayed 3. Apply this patch and reload 4. Repeat 2 => SUCCESS: SRU server displayed! => SUCCESS: No authority server is displayed due to the change i.e. behavior remains unchanged besides SRU support 5. Choose the sample SRU server and make a search => SUCCESS: Things work 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- I'm having trouble telling whether it works somehow but ignores the SRU mapping, or it isn't actually using the LC SRU server. If I swap the mapping between the title and ISBN fields, the ISBN field still only searches for ISBN and the title field only searches for titles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41015 [Bug 41015] Z39.50 searching in Advanced Cataloging Editor is not clearly labeled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188608|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 189045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189045&action=edit Bug 41136: Allow advanced editor to search SRU servers This patch makes the advanced editor be able to search on SRU servers also, instead of only Z39.50. To test: 0. On a fresh KTD 1. Enable and open the cataloguing advanced editor 2. Click on 'Advanced >>' on the left column => FAIL: Only non-SRU targets are displayed 3. Apply this patch and reload 4. Repeat 2 => SUCCESS: SRU server displayed! => SUCCESS: No authority server is displayed due to the change i.e. behavior remains unchanged besides SRU support 5. Choose the sample SRU server and make a search => SUCCESS: Things work 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the advanced release notes| |cataloging editor so that | |SRU servers are now shown | |(and work) for the advanced | |search, instead of only | |Z39.50 servers. See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41015 CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- And given that if you do something like map LC Call Number to something that should exist, like dc:title, you get the error "Unsupported Use attribute" which is a Z39.50 message and the one you get from just using the LC Call Number search on Library of Congress Z39.50, I really doubt that it's actually doing SRU at all. Since the hostname, port, and database name are all the same for LC's Z39.50 and SRU, I think what we're testing is that the advanced editor ignores the servertype. At the very least, the test plan needs to use a server which doesn't share a hostname, port, and database name between SRU and Z39.50. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Phil Ringnalda from comment #9)
And given that if you do something like map LC Call Number to something that should exist, like dc:title, you get the error "Unsupported Use attribute" which is a Z39.50 message and the one you get from just using the LC Call Number search on Library of Congress Z39.50, I really doubt that it's actually doing SRU at all. Since the hostname, port, and database name are all the same for LC's Z39.50 and SRU, I think what we're testing is that the advanced editor ignores the servertype.
At the very least, the test plan needs to use a server which doesn't share a hostname, port, and database name between SRU and Z39.50.
Are you reporting the SRU feature is all broken? Or just in the advanced editor? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #10)
Are you reporting the SRU feature is all broken? Or just in the advanced editor?
I believe that I am reporting that the advanced editor's search implementation doesn't actually perform SRU at all, and that's why it only selects servertype='zed'. https://git.koha-community.org/Koha-community/Koha/src/commit/b385f7b4ec250d... looks fairly supportive of that. Given the info to create another SRU server which does not have the exact same hostname, port, and database name for both its Z39.50 and SRU endpoints (as the Library of Congress does) we would be able to see that the advanced editor's search only does Z39.50, not SRU. Lacking that, I was just using SRU search field mapping as a way to try to see that it wasn't actually doing SRU. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40841 | Depends on| |40841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40841 [Bug 40841] Limit z39.50 targets to specific branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41136 trevor.diamond@mainlib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trevor.diamond@mainlib.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org