https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Template changes made by |Corrections to templates |EDI feature should use Font |related new EDI feature |Awesome icons | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I'm changing the title of this bug to reflect the wider scope of the changes I'm preparing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49924&action=edit Bug 16206 - Corrections to templates related new EDI feature There are some issues with the template changes introduced by the EDI feature in Bug 7736. This patch makes the following changes: - Use Font Awesome icon on the Acquisitions basket page instead of a Glyphicon. - Use Font Awesome icon on the Acquisitions basket group page instead of a Glyphicon. - For consistency's sake, use the phrase "Library EANs" instead of "EDI EANs" in menus and the Library EANs page. - On the EDI accounts page: - Correct the markup of the title tag. - Improve the breadcrumbs to eliminate redundancy. - Use Font Awesome icon instead of Glyphicon for the "New account" button. - Change or remove "maxlength" attribute of form fields to match table structure. - Move the contents of some title attributes into a visible hint. - Use 'checked="checked"' instead of 'checked'. Koha templates use XTHML-style attributes. - Correct template variable in account deletion confirmation dialog. Before this patch the vendor name was not correctly displayed. - Show a message if there are no accounts defined rather than an empty table. - Remove use of "highlight" class from table rows (Bug 15927). - Correct parameter name in link to vendor details page (should be booksellerid instead of supplierid). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. - On the Library EANs page: - Correct the markup of the title tag. - Make capitalization of "EAN" consistent. - Use Font Awesome icon instead of Glyphicon for the "New EAN" button. - Show a message if there are no EANs defined rather than an empty table. - Change or remove "maxlength" attribute of form fields to match table structure. - Remove use of "highlight" class from table rows (Bug 15927). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. To test, apply the patch and review the affected templates. Confirm that pages look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49924|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 50005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50005&action=edit [SIGNED-OFF] Bug 16206: Corrections to templates related new EDI feature There are some issues with the template changes introduced by the EDI feature in Bug 7736. This patch makes the following changes: - Use Font Awesome icon on the Acquisitions basket page instead of a Glyphicon. - Use Font Awesome icon on the Acquisitions basket group page instead of a Glyphicon. - For consistency's sake, use the phrase "Library EANs" instead of "EDI EANs" in menus and the Library EANs page. - On the EDI accounts page: - Correct the markup of the title tag. - Improve the breadcrumbs to eliminate redundancy. - Use Font Awesome icon instead of Glyphicon for the "New account" button. - Change or remove "maxlength" attribute of form fields to match table structure. - Move the contents of some title attributes into a visible hint. - Use 'checked="checked"' instead of 'checked'. Koha templates use XTHML-style attributes. - Correct template variable in account deletion confirmation dialog. Before this patch the vendor name was not correctly displayed. - Show a message if there are no accounts defined rather than an empty table. - Remove use of "highlight" class from table rows (Bug 15927). - Correct parameter name in link to vendor details page (should be booksellerid instead of supplierid). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. - On the Library EANs page: - Correct the markup of the title tag. - Make capitalization of "EAN" consistent. - Use Font Awesome icon instead of Glyphicon for the "New EAN" button. - Show a message if there are no EANs defined rather than an empty table. - Change or remove "maxlength" attribute of form fields to match table structure. - Remove use of "highlight" class from table rows (Bug 15927). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. To test, apply the patch and review the affected templates. Confirm that pages look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All seems to work and looks well, add/edit/delete EDI accounts and Library EANs works Ok No errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16237 [Bug 16237] Adding new EDI account results in Perl error when plugins are not activated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50005|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50223&action=edit [PASSED QA] Bug 16206: Corrections to templates related new EDI feature There are some issues with the template changes introduced by the EDI feature in Bug 7736. This patch makes the following changes: - Use Font Awesome icon on the Acquisitions basket page instead of a Glyphicon. - Use Font Awesome icon on the Acquisitions basket group page instead of a Glyphicon. - For consistency's sake, use the phrase "Library EANs" instead of "EDI EANs" in menus and the Library EANs page. - On the EDI accounts page: - Correct the markup of the title tag. - Improve the breadcrumbs to eliminate redundancy. - Use Font Awesome icon instead of Glyphicon for the "New account" button. - Change or remove "maxlength" attribute of form fields to match table structure. - Move the contents of some title attributes into a visible hint. - Use 'checked="checked"' instead of 'checked'. Koha templates use XTHML-style attributes. - Correct template variable in account deletion confirmation dialog. Before this patch the vendor name was not correctly displayed. - Show a message if there are no accounts defined rather than an empty table. - Remove use of "highlight" class from table rows (Bug 15927). - Correct parameter name in link to vendor details page (should be booksellerid instead of supplierid). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. - On the Library EANs page: - Correct the markup of the title tag. - Make capitalization of "EAN" consistent. - Use Font Awesome icon instead of Glyphicon for the "New EAN" button. - Show a message if there are no EANs defined rather than an empty table. - Change or remove "maxlength" attribute of form fields to match table structure. - Remove use of "highlight" class from table rows (Bug 15927). - Correct the markup of the deletion confirmation dialog (Bug 15785). - Use Bootstrap-style buttons for "edit" and "delete," with Font Awesome icons. To test, apply the patch and review the affected templates. Confirm that pages look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All seems to work and looks well, add/edit/delete EDI accounts and Library EANs works Ok No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16208 [Bug 16208] Can't delete a library EAN if the EAN value is empty -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16206 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.