[Bug 12342] New: Patron registration datepicker dropdown shows only 10 years
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Bug ID: 12342 Summary: Patron registration datepicker dropdown shows only 10 years Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Registering a new patron, click on the date of birth -date picker, the year dropdown only shows 10 years (eg. 2004 - 2014). It should show 20 years, to catch most patrons to be registered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 IT-and-COMM <IT@bibliothek-grossauheim.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |IT@bibliothek-grossauheim.d | |e -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #1 from IT-and-COMM <IT@bibliothek-grossauheim.de> --- Well it should show _at least_ 20 entries. And it should start five years in the past, since patrons creation requests for the age from 0 years to 5 years are not dropping in that frequently. Do they? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #2 from Martin Persson <xarragon@gmail.com> --- Created attachment 39089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39089&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |xarragon@gmail.com |ity.org | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39089|0 |1 is obsolete| | --- Comment #3 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39098&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |eskaaren@yahoo.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hello Martin Very useful patch, thanks! Could you have a look at the following template: opac-memberentry.tt: $( "#borrower_dateofbirth" ).datepicker({ yearRange: "c-120:c" }); To be consistent, it would be good to have the same value everywhere. Feel free to replace 120 with 100 or vice versa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Switch the status back to Signed Off when done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39098|0 |1 is obsolete| | --- Comment #6 from Martin Persson <xarragon@gmail.com> --- Created attachment 45379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45379&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45379|0 |1 is obsolete| | --- Comment #7 from Martin Persson <xarragon@gmail.com> --- Created attachment 45380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45380&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45380|0 |1 is obsolete| | --- Comment #8 from Martin Persson <xarragon@gmail.com> --- Created attachment 45381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45381&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. Updated version with proper description and default value moved to a separate bug/commit. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45381|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45389&action=edit [SIGNED-OFF]Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #10 from Martin Persson <xarragon@gmail.com> --- I realized I should have changed the format string to "c-120:c", but since it is signed off.. well, hardly worth it. Doing it would allow us to drop the "maxDate" attribute. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Martin Persson from comment #10)
I realized I should have changed the format string to "c-120:c", but since it is signed off.. well, hardly worth it. Doing it would allow us to drop the "maxDate" attribute.
Hi Martin If you want to do another change in patch, do it, I will sign-off again. Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This seems to work fine as it is - passing QA. Please let me know if you want to do a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45389|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45433&action=edit [PASSED QA] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org