[Bug 35356] New: SMS number field shows on moremember.pl even when null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Bug ID: 35356 Summary: SMS number field shows on moremember.pl even when null Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Generally, the patron record details on moremember.pl don't show the labels for fields for which there is no data -- for example, if your patron doesn't have an email address, we don't show the Email field at all. However, we're not consistent about this with SMS Number. If the SMSSendDriver syspref has a value, then every patron will show "SMS Number" under the messaging prefs table on moremember.pl, even if they don't have any value there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159114&action=edit Bug 35356: Show SMS labels only when data exists To test: APPLY PATCH 1. Set SMSSendDriver = Email 2. Admin > SMS cellular providers, have at least 1. 3. Go to the members/moremember.pl 4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear. 5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159114|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 159117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159117&action=edit Bug 35356: Show SMS labels only when data exists To test: APPLY PATCH 1. Set SMSSendDriver = Email 2. Admin > SMS cellular providers, have at least 1. 3. Go to the members/moremember.pl 4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear. 5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159117|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159214&action=edit Bug 35356: Show SMS labels only when data exists To test: APPLY PATCH 1. Set SMSSendDriver = Email 2. Admin > SMS cellular providers, have at least 1. 3. Go to the members/moremember.pl 4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear. 5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA Severity|minor |enhancement --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Generally, the patron record details on moremember.pl don't show the labels for fields for which there is no data -- for example, if your patron doesn't have an email address, we don't show the Email field at all. However, we're not consistent about this with SMS Number
Even though, this really looks more like an enhancement. Regardless, I noticed too late ^^ It works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement, no backport for 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org