[Bug 17737] New: Move GetReservesFromItemnumber to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Bug ID: 17737 Summary: Move GetReservesFromItemnumber to Koha::Item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromItemnumber |GetReservesFromItemnumber |to Koha::Item |to Koha::Item->get_holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->get_holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->get_holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move |Move |GetReservesFromItemnumber |GetReservesFromItemnumber |to Koha::Item->get_holds |to Koha::Item->holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58018&action=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58019&action=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please see 17736 and use something like current_holds ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58018|0 |1 is obsolete| | Attachment #58019|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58673&action=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58674&action=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58675&action=edit Bug 17737: Rename holds_placed_before_today with current_holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Running Reserves.t ok 51 - Reserve in waiting status cant be canceled Use of uninitialized value $tagno in concatenation (.) or string at /usr/share/perl5/MARC/Field.pm line 83. Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 525. # Looks like your test exited with 255 just after 51. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18045 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #7)
Running Reserves.t
ok 51 - Reserve in waiting status cant be canceled Use of uninitialized value $tagno in concatenation (.) or string at /usr/share/perl5/MARC/Field.pm line 83. Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 525. # Looks like your test exited with 255 just after 51.
Not related with these patches, see bug 18045. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59872&action=edit Bug 17737: [QA Follow-up] Remove unused reservedfor variable The changes in this patch set obsolete this variable. Remove confusing comment about reserve via host record. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Minor inconsistency on the interface: if I set OPACShowHoldQueueDetails and place a future hold, opac-details says Available but also 1 (priority 1). Should be resolved somewhere else though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +my $item = Koha::Items->find( $itemnumber ); +$holds = $item->holds_placed_before_today; +my $dtf = Koha::Database->new->schema->storage->datetime_parser; +my $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } ); +is( $future_holds->count, 0, 'holds_placed_before_today does not return a future next available hold'); +# 9788b: holds_placed_before_today does not return future item level hold Hm. You look at future_holds and then say something about the results of holds_placed_before_today as saved in holds ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seems the same for two other occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Need feedback on comment 11 before signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #13)
Need feedback on comment 11 before signoff.
No longer, just misread the search call. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58673|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59876&action=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58674|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59877&action=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58675|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59878&action=edit Bug 17737: Rename holds_placed_before_today with current_holds Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59872|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59879&action=edit Bug 17737: [QA Follow-up] Remove unused reservedfor variable The changes in this patch set obsolete this variable. Remove confusing comment about reserve via host record. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Success, Martin. You can do it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Bug 17737 depends on bug 17736, which changed state. Bug 17736 Summary: Move GetReservesFromBiblionumber to Koha::Biblio->holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Taking the liberty to pass QA on this one now. Retested. QA tools do not complain. Tests pass. Looks still good to me, no need to wait any longer. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This also gets the thumbs up from me, it was in my queue to properly QA but I'd been pulled into other things part way through. As Marcel says, it passes all the tests and the code looks good to me. As far through my manual checks and testing it had all passed with flying colours too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #21)
This also gets the thumbs up from me, it was in my queue to properly QA but I'd been pulled into other things part way through. As Marcel says, it passes all the tests and the code looks good to me. As far through my manual checks and testing it had all passed with flying colours too.
Thanks, Martin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59876|0 |1 is obsolete| | Attachment #59877|0 |1 is obsolete| | Attachment #59878|0 |1 is obsolete| | Attachment #59879|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62105&action=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62106&action=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62107&action=edit Bug 17737: Rename holds_placed_before_today with current_holds Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62108&action=edit Bug 17737: [QA Follow-up] Remove unused reservedfor variable The changes in this patch set obsolete this variable. Remove confusing comment about reserve via host record. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just a rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org