[Bug 20554] New: New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Bug ID: 20554 Summary: New OPAC CSS Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org A suggestion for updating the OPAC CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |claire_gravely@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #1 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 73941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73941&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 73942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73942&action=edit Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20427, 20552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 [Bug 20427] Convert OPAC LESS to SCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 [Bug 20552] Fix HTML tag for search facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73941|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 74090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74090&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73942|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 74091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74091&action=edit Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen@inlibro.com --- Comment #5 from Maksim Sen <maksim.sen@inlibro.com> --- Can I have a test plan so I can sign off your bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Roch D'Amour <roch.damour@inlibro.com> --- Woops! I tried applying to patch and take a look at it, but it didn't apply. I got a sha1 error : .git/rebase-apply/patch:32: trailing whitespace. font-family: 'NotoSansRegular'; .git/rebase-apply/patch:315: trailing whitespace. font-family: 'NotoSansRegular'; .git/rebase-apply/patch:342: trailing whitespace. .git/rebase-apply/patch:362: trailing whitespace. } .git/rebase-apply/patch:495: trailing whitespace. } fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74656&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74091|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74657&action=edit Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74090|0 |1 is obsolete| | Attachment #74656|0 |1 is obsolete| | Attachment #74657|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74715&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74716&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74717&action=edit Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74716|0 |1 is obsolete| | Attachment #74717|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76523&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76524&action=edit Bug 20554: (follow-up) Compiled CSS This patch includes the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Bug 20554 depends on bug 20427, which changed state. Bug 20427 Summary: Convert OPAC LESS to SCSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74715|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77689&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76523|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77690&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #16 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77906&action=edit Screenshot of the OPAC homepage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #17 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77907&action=edit Screenshot of the OPAC Results list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #18 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77908&action=edit Screenshot of the OPAC drop down menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #19 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77909&action=edit Screenshot of the OPAC detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #20 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77913&action=edit Screenshot of the borrower account fines tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |dilan@calyx.net.au --- Comment #21 from Dilan Johnpullé <dilan@calyx.net.au> --- I've just run into issues trying to apply this patch too :/ vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20554 Bug 20554 - New OPAC CSS 77689 - Bug 20554: New OPAC CSS 77690 - Bug 20554: (follow-up) Add local font files and add method for loading them Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20554: New OPAC CSS Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Applying: Bug 20554: (follow-up) Add local font files and add method for loading them Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/lib/fontfaceobserver.min.js Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 20554: (follow-up) Add local font files and add method for loading them The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20554-follow-up-Add-local-font-files-and-add-m-Hfq677.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77689|0 |1 is obsolete| | Attachment #77690|0 |1 is obsolete| | --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78257&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78258&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78258|0 |1 is obsolete| | --- Comment #24 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 78360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78360&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does no longer apply. Can you detail the different changes we are suppose to see? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78257|0 |1 is obsolete| | Attachment #78360|0 |1 is obsolete| | --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78666&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78667&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Padding should be removed for mobile views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #29 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 78730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78730&action=edit Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. https://bugs.koha-community.org/show_bug.cgi?id=20054 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #30 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 78731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78731&action=edit Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78666|0 |1 is obsolete| | Attachment #78667|0 |1 is obsolete| | Attachment #78731|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78811&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78813&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78814&action=edit Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Works as expected. IMO it's too bright, but we could get more opinions once pushed ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #34)
Works as expected. IMO it's too bright, but we could get more opinions once pushed ;)
Haha, there's always someone wanting a 'Dark theme'. I too would appreciate an enhancement that allowed basic colour scheme selection allowing the end user to select between 'light' and 'dark' modes (or for the accesablity minded amongst us a 'high contrast' mode?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Elaine Bradtke <eb@efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb@efdss.org --- Comment #36 from Elaine Bradtke <eb@efdss.org> --- I would appreciate a high contrast mode. The screen shots are low resolution, but even still, I'd prefer strong contrast and ease of reading over cosmetic changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm afraid I can't get this to apply against master now :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78811|0 |1 is obsolete| | Attachment #78813|0 |1 is obsolete| | Attachment #78814|0 |1 is obsolete| | --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79905&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79906&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79907&action=edit Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm afraid I'm not sure that rebase worked well.. I'm getting some very odd display now, not much like the screenshots attached here at all. I ran the `yarn build --view opac` command and restarted memcached and apache (not a plack install here).. is there anything I'm missing ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- After some investigation it seems ` OpacAdditionalStylesheet ` must contain ` opac.css ` for this patch to work.. is that expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Please rebase :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79905|0 |1 is obsolete| | Attachment #79906|0 |1 is obsolete| | Attachment #79907|0 |1 is obsolete| | --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80742&action=edit Bug 20554: New OPAC CSS A suggestion for updating the OPAC CSS This patch updates the css styling of the OPAC Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80743&action=edit Bug 20554: (follow-up) Add local font files and add method for loading them This patch adds local copies of the font files specified in the original patch. A new JavaScript file has been added, fontfaceobserver.min.js, which helps gracefully load font assets. https://github.com/bramstein/fontfaceobserver Information about the new assets has been added to the about page. When using web fonts, there can be a delay, while the browser loads the font files, between the time the page loads and the time the fonts render. Font Face Observer allows us to specify a default font for the initial page render, and then apply the web font after it has loaded. To test, apply the patch and regenerate the OPAC css. View any page in the OPAC and confirm that the custom font renders properly. View the About page in the staff client and confirm that the new license information looks correct. Patch applies and OPAC and license look good. Looking forward to this. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80744&action=edit Bug 20554: (QA follow up) Remove padding in mobile view This patch removes the padding for mobile screen sizes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Bug 20554 depends on bug 20552, which changed state. Bug 20552 Summary: Fix HTML tag for search facets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #48 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 81067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81067&action=edit Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by Asset.css() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81067|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81068&action=edit Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by Asset.css() Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Fix a bad resolution conflict -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #49)
Created attachment 81068 [details] [review] Bug 20554: (follow-up) KOHA_VERSION is not needed in opaclayoutstylesheet
SET opaclayoutstylesheet does not need KOHA_VERSION, its defined by Asset.css()
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Fix a bad resolution conflict
Followup pushed to master for 18.11, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver.behnke@aei.mpg.de --- Comment #52 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi everyone, unfortunately the self-checkout module has been neglected/missed again and the nice new theme isn't yet applied to it, leading to an inconsistent UI. What's the easiest way to fix that? Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Oliver Behnke from comment #52)
Hi everyone, unfortunately the self-checkout module has been neglected/missed again and the nice new theme isn't yet applied to it, leading to an inconsistent UI. What's the easiest way to fix that?
Cheers
Please file a new bug :) (see my other comment) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22274 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #54 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 [Bug 22274] Self-checkout pages not covered by OPAC CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22274 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 [Bug 22274] Self-checkout pages not covered by OPAC CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #55 from David Cook <dcook@prosentient.com.au> --- By the way, fontfaceobserver.min.js is getting flagged as the Miner.Jswebcoin virus by Symantec Endpoint Protection. It says that Symantec have had it flagged for more than 1 year, and that the file is untrustworthy. I have examined the Javascript, and it really appears to be a false positive, but I'm noting it here anyway. I'm going to look at removing fontfaceobserver locally so that it can pass security checks for the time being. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #55)
By the way, fontfaceobserver.min.js is getting flagged as the Miner.Jswebcoin virus by Symantec Endpoint Protection.
It says that Symantec have had it flagged for more than 1 year, and that the file is untrustworthy.
I have examined the Javascript, and it really appears to be a false positive, but I'm noting it here anyway.
I'm going to look at removing fontfaceobserver locally so that it can pass security checks for the time being.
Hi David, if we need to do something about this, please file a new bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #57 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #56)
(In reply to David Cook from comment #55)
By the way, fontfaceobserver.min.js is getting flagged as the Miner.Jswebcoin virus by Symantec Endpoint Protection.
It says that Symantec have had it flagged for more than 1 year, and that the file is untrustworthy.
I have examined the Javascript, and it really appears to be a false positive, but I'm noting it here anyway.
I'm going to look at removing fontfaceobserver locally so that it can pass security checks for the time being.
Hi David, if we need to do something about this, please file a new bug report.
At this point, I'm still waiting to hear back from Symantec. I'm hoping that they'll check this out, and update their virus definitions to no longer include fontfaceobserver. Locally, we've disabled fontfaceobserver for those using Symantec Endpoint Protection, so that they don't get the virus alert anymore. But I don't think there's anything that needs to be done on the Koha community side of things at this point. Just giving people a FYI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 [Bug 35642] Upgrade Font Face Observer library from v2.0.3 to v2.3.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org