[Bug 12674] New: GetMarcISSN should not return empty ISSN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Bug ID: 12674 Summary: GetMarcISSN should not return empty ISSN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Currently, GetMarcISSN returns an array of all present ISSN on a specific record. Unlike the GetMarcISBN counterpart, it doesn't filter empty ISSNs out. To reproduce, run the attached regression test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12554 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30304&action=edit Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30305&action=edit Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30304|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31284&action=edit Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30305|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31285&action=edit Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31284|0 |1 is obsolete| | Attachment #31285|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31287&action=edit [PASSED QA] Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN Proves GetMarcISSN returns empty ISSNs in the results array. To reproduce: - Run $ prove -v t/db_dependent/Biblio.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31288&action=edit [PASSED QA] Bug 12674: GetMarcISSN should not return empty ISSN This patch makes GetMarcISSN test for empty subfield before pushing to the result array. To test: - Run the regression test => FAILS for all MARC flavours - Apply the patch - Run the regression test => SUCCESS: tests pass - Sign off Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org