[Bug 12255] New: Amazon cover images have useless image alt text in bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Bug ID: 12255 Summary: Amazon cover images have useless image alt text in bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org opac-tmpl/bootstrap/en/modules/opac-user.tt: alt="item-thumbnail" class="item-thumbnail" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 28447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28447&action=edit Bug 12255 - Amazon cover images have useless image alt text in bootstrap "item-thumbnail" is not a useful alt text for an Amazon book cover image. Better would be the link's title text, "View on Amazon.com." This patch makes this correction. (Rather than "View at Amazon.com" which doesn't sound correct to me). To test you must have the OPACAmazonCoverImages system preference enabled. Log in to the OPAC and view your list of checked-out titles. The alt text for cover images should be "View on Amazon.com." Test in both prog and Bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I think something like "Amazon.com book cover image" might actually make more appropriate alt text, since - at least from an accessibility point of view - the alt text should describe the content that it replaces. http://www.w3.org/standards/webdesign/accessibility -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #2)
I think something like "Amazon.com book cover image" might actually make more appropriate alt text
I would contend that "Amazon.com book cover image" is not useful information to a person who is navigating the the interface without images. Is it useful to them to know that there is a book cover image there? I would say no, but obviously I'm guessing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #3)
(In reply to David Cook from comment #2)
I think something like "Amazon.com book cover image" might actually make more appropriate alt text
I would contend that "Amazon.com book cover image" is not useful information to a person who is navigating the the interface without images. Is it useful to them to know that there is a book cover image there? I would say no, but obviously I'm guessing.
I should ask some of my accessibility friends :). Admittedly, I'm mostly making guesses as well. I think that alt text of "Amazon.com book cover image" would let people know that's the thing that they're not seeing. In terms of "View at Amazon.com", that is already being provided by the "a" element. Screen readers will pick that up, and sighted users can notice it when hovering over the link. I think there are cases when the alt text is supposed to be useful data. For instance...say you have button images, and one is red to show that it's "active" in comparison to the "inactive" blue images. In that case, I imagine something like "active button" or "active tab" or something like that would be useful. It's still a description, but actually useful, whereas "Amazon.com book cover image" isn't really useful...but is still descriptive. At least, I think that's roughly how it works. Happy to be educated otherwise. I'll send out some feelers to the folk I know who work/need in accessibility. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Taking a look at Wikipedia... http://en.wikipedia.org/wiki/Wikipedia:Alternative_text_for_images Here's a particularly relevant section: http://en.wikipedia.org/wiki/Wikipedia:Alternative_text_for_images#Importanc... Since the purpose of the cover image is mostly aesthetic, I think minimal text describing what the image is makes the most sense. I'll see what my accessibility folk come back with, but since we can't individually curate alt text for dynamically generated images, I think "Amazon.com book cover image" is a good choice. Or something similar to that. I'm actually not that committed to that string of text. I just want to make sure that we're adhering as closely as possible to WCAG 2.0 ^_^ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Ok, I'm a bit of a keener... Liz Rea suggested the alt text of "cover image for <title of book>". I have a partially blind friend who appears to think that is also a good idea. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Ok, so here's a quote from my friend in regards to link text: "I'd want to see it say it is a cover of (title) and maybe the link info i.e. like you're saying view on amazon. So I was trying to imply that same method would hold true for most images, say you have a photo of a statue, you'd say statue of (statue name/description) links to (whatever it links to maybe larger version)." Using that formula, we would come up with something like: "Cover of <resource title>. View on Amazon.com" So...both my suggestion, Liz's, and Owen's? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28447|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 28790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28790&action=edit [SIGNED OFF] Bug 12255 - Amazon cover images have useless image alt text in bootstrap "item-thumbnail" is not a useful alt text for an Amazon book cover image. Better would be the link's title text, "View on Amazon.com." This patch makes this correction. (Rather than "View at Amazon.com" which doesn't sound correct to me). To test you must have the OPACAmazonCoverImages system preference enabled. Log in to the OPAC and view your list of checked-out titles. The alt text for cover images should be "View on Amazon.com." Test in both prog and Bootstrap. NOTE: You'll need one to be overdue in order to trigger both cases. Examine the HTML for both tabs in the person details page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- The problem is the image with the alt is inside an href with an alt. I don't know about you, but my href alt over-rode my image alt. Though this patch does correctly change the image alt, it may not have a visible effect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #9)
The problem is the image with the alt is inside an href with an alt.
Nope. The <a> has a title attribute.
I don't know about you, but my href alt over-rode my image alt.
The link's title attribute doesn't "override" the alt attribute. The alt attribute is a brief textual description of the image in question which will be visible with images turned off, read in a text-only browser, or spoken by screen reader software. The title attribute, for sighted users of graphical browsers, triggers a tooltip on hover to provide additional information about an element.
Though this patch does correctly change the image alt, it may not have a visible effect.
Nor should it. The alt attribute is not designed to produce a visible effect. http://www.456bereastreet.com/archive/200604/alt_text_is_an_alternative_not_... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Okay. It is functioning as expected. It just seems weird to have the title display as a tooltip under firefox and the alt not be visible as a tooltip at all. As such, I stand by my signoff, because this is doing what it should do. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am going to pass this patch, but there are quite a few places that are not caught yet: - result list - detai page - shelf browser - staff :) The patch touches the prog theme, but it's not adding a new feature - follow ups probably should only change the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28790|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29133&action=edit Bug 12255 - Amazon cover images have useless image alt text in bootstrap "item-thumbnail" is not a useful alt text for an Amazon book cover image. Better would be the link's title text, "View on Amazon.com." This patch makes this correction. (Rather than "View at Amazon.com" which doesn't sound correct to me). To test you must have the OPACAmazonCoverImages system preference enabled. Log in to the OPAC and view your list of checked-out titles. The alt text for cover images should be "View on Amazon.com." Test in both prog and Bootstrap. NOTE: You'll need one to be overdue in order to trigger both cases. Examine the HTML for both tabs in the person details page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This fixed the cover alt texts for Amazon covers in the patron account for checkouts, overdues and holds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. David: if you haven't done so already, I recommend that you open a new bug for further improvements to the alt text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Galen Charlton from comment #15)
Pushed to 3.16.x for inclusion in 3.16.1.
David: if you haven't done so already, I recommend that you open a new bug for further improvements to the alt text.
Thanks, Galen. I've been pondering it. I think I might take a break and recharge my Koha batteries for a bit first though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #16)
(In reply to Galen Charlton from comment #15)
Pushed to 3.16.x for inclusion in 3.16.1.
David: if you haven't done so already, I recommend that you open a new bug for further improvements to the alt text.
Thanks, Galen. I've been pondering it. I think I might take a break and recharge my Koha batteries for a bit first though.
Actually, I'll report it, but I probably won't post a patch for a while. Not feeling very enthusiastic about contributing code at the moment. Will take another look when the batteries are charged again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #17)
(In reply to David Cook from comment #16)
(In reply to Galen Charlton from comment #15)
Pushed to 3.16.x for inclusion in 3.16.1.
David: if you haven't done so already, I recommend that you open a new bug for further improvements to the alt text.
Thanks, Galen. I've been pondering it. I think I might take a break and recharge my Koha batteries for a bit first though.
Actually, I'll report it, but I probably won't post a patch for a while. Not feeling very enthusiastic about contributing code at the moment. Will take another look when the batteries are charged again.
Ok, I think that might've been passive aggressive. I didn't mean it to be. I do want the alt text to be improved, because I think Koha should be as accessible as possible. I will open a new bug. I'm just not feeling as enthusiastic as I usually am about contributing to Koha. I mean this in general not just related to this bug. I feel a bit agitated. I feel a bit defeated. I feel like contributing is an uphill battle that doesn't always feel worth it, even if it is ridiculous as I don't contribute (or try to contribute) anywhere near as much as I would like. And while it's fine to have those feelings...it's not very helpful for me to just whine about it or to be passive aggressive. There are people (like Galen, Owen, and Katrin) who put so much blood and sweat into Koha and rarely (if ever) complain. They just keep working hard. I'm a pretty passionate person, but I find that passion is difficult to sustain sometimes. Progress is slow and this can be frustrating when what you want to do is move fast. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12255 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12474 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org