https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@gmail.com, | |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- It does find the first one, which is a vague clue. It's actually a Tidy regression: in https://git.koha-community.org/Koha-community/Koha/src/commit/e0ebd409917c6c... Jonathan thought the comment would keep people from indenting the line, but then his autotidy code ignored his comment. Seems odd that Koha::Patrons->find ignores leading whitespace for borrowernumber but treats it as significant for cardnumber. And if it does have to do that for some historical reason, then the first cardnumber will be broken when it has significant leading whitespace, since we | trim the output of PROCESS batch_list (which is the reason it currently does find the first cardnumber). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187437|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 187480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187480&action=edit Bug 40939: Fix batch actions from report results Batch patron operations are broken when using cardnumbers From commit d659526b5ae3363de6dc7691a782a45aaf781a46 Bug 38664: Tidy the whole codebase - [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] -[%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] + [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] + [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] The auto tidy added the whitespaces back This patch suggests to use TT to add the new lines. + [%- cells.cell | html -%][% "\n" | $raw %][%# We want 1 item per line, without whitespace %] Test plan: - save and run "SELECT cardnumber FROM borrowers" - use the Batch Operations button to send all visible cardnumbers to batch patron modification - see that all of your cardnumbers have been found Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187480|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188050&action=edit Bug 40939: Fix batch actions from report results Batch patron operations are broken when using cardnumbers From commit d659526b5ae3363de6dc7691a782a45aaf781a46 Bug 38664: Tidy the whole codebase - [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] -[%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] + [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] + [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] The auto tidy added the whitespaces back This patch suggests to use TT to add the new lines. + [%- cells.cell | html -%][% "\n" | $raw %][%# We want 1 item per line, without whitespace %] Test plan: - save and run "SELECT cardnumber FROM borrowers" - use the Batch Operations button to send all visible cardnumbers to batch patron modification - see that all of your cardnumbers have been found Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38664 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.