[Bug 6868] New: Need a script to fix bad accountno data in accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Bug #: 6868 Summary: Need a script to fix bad accountno data in accountlines Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com A pretty serious, and heretofore unidentified bug was causing the accountlines.accountno to increment based on the max accountno in the entire accountlines table. This would cause the SMALL_INT to reach max far more quickly than it should have. The bug that caused the problem was fixed with the patch that was submitted and pushed for bug 3498, but that wouldn't repair the problem in the data - each borrowernumber should have 32767 lines available to it, but in all databases that have been privy to this bug, that wouldn't be correct - numbers would have been skipped based on the max accountno at the time of the writeoff. What is needed is a script to clean up the accountno for each borrower, to increment it correctly and free all remaining available lines for each borrower. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-14 20:07:25 UTC --- Created attachment 5429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5429 Cleanup Script for accountlines This script cleans up damage to the accountlines table caused by the writeoff() subroutine in members/pay.pl (pre bug 3498 integration). Includes two flags: -t Runs this in test mode. The database is not actually updated; if omitted, the changes run on database directly. -v Prints out every change made to screen; if omitted, just shows progress counter This script can take some time to run; 8000 updates in 5:30 minutes on a powerful system, in my experience. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com AssignedTo|kyle.m.hall@gmail.com |ian.walls@bywatersolutions. | |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |wizzyrea@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5429|0 |1 is patch| | Attachment #5429|application/x-perl |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5429|1 |0 is patch| | Attachment #5429|text/plain |application/x-perl mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-11-04 19:35:19 UTC --- Shouldn't this attachment be formatted as a patch? Is there a way to create the conditions necessary to test this patch on a system which doesn't have the problem? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-02 06:25:25 UTC --- Created attachment 6505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6505 Bug 6868 : Script to clean up accountno This script cleans up damage to the accountlines table caused by the writeoff() subroutine in members/pay.pl (pre bug 3498 integration). Includes two flags: -t Runs this in test mode. The database is not actually updated; if omitted, the changes run on database directly. -v Prints out every change made to screen; if omitted, just shows progress counter This script can take some time to run; 8000 updates in 5:30 minutes on a powerful system, in my experience. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-06 07:20:34 UTC --- I am not sure how to test this. Can you provide a test plan? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-06 21:47:20 UTC --- Hi Katrin The error was if you had over 32000ish accounts then the number had hit its max. Its pretty hard to test, you would have to get a create a borrower over that many lines in accountlines. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> 2011-12-07 15:42:44 UTC --- Also, I'm not so sure this really needs to be somehow integrated into Koha? Perhaps just having the script available for people to download and use is enough? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-08 01:10:56 UTC --- Good point, maybe a link to this bug/patch on the wiki ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |--- --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-31 06:48:21 UTC --- Script won't be pushed, leaving open for people who need it to be able to find it -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6868 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P3 CC| |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org