[Bug 27982] New: Replace obsolete title-string sorting: Acquisitions templates part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Bug ID: 27982 Summary: Replace obsolete title-string sorting: Acquisitions templates part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, koha-bugs@lists.koha-community.org, kyle.m.hall@gmail.com, m.de.rooy@rijksmuseum.nl, martin.renvoize@ptfs-europe.com, oleonard@myacpl.org, sally.healey@cheshiresharedservices.gov.uk, testopia@bugs.koha-community.org, tomascohen@gmail.com Blocks: 27934 This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt intranet-tmpl/prog/en/modules/acqui/booksellers.tt intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt intranet-tmpl/prog/en/modules/acqui/histsearch.tt intranet-tmpl/prog/en/modules/acqui/invoice-files.tt intranet-tmpl/prog/en/modules/acqui/invoice.tt intranet-tmpl/prog/en/modules/acqui/invoices.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934 [Bug 27934] Table sorting using title-string option is obsolete -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118468&action=edit Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118468|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118491&action=edit Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118580&action=edit Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118491|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118783&action=edit Bug 27982: (follow-up) Address missing instances - Acquisitions -> Invoices - With AcqEnableFiles enabled, attach some files to an invoice: - Invoice details -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118786&action=edit Bug 27982: (follow-up) Address another missing instance Remove "title-string" option from invoice-files dataTable initialization. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118786|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118787&action=edit Bug 27982: (follow-up) Address another missing instance Remove "title-string" option from staged file dataTable initialization. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118580|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118845&action=edit Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118783|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118846&action=edit Bug 27982: (follow-up) Address missing instances - Acquisitions -> Invoices - With AcqEnableFiles enabled, attach some files to an invoice: - Invoice details Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118787|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118847&action=edit Bug 27982: (follow-up) Address another missing instance Remove "title-string" option from staged file dataTable initialization. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Applied 27982 and 27983 together. Grepped for title-string in the acqui dir and in js includes. No further cases found.. well caught on the extra's Owen. Passing QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27982 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Staff Client -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org