[Bug 33581] New: Error in Webinstaller concerning sample holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Bug ID: 33581 Summary: Error in Webinstaller concerning sample holidays Change sponsored?: --- Product: Koha Version: 22.11 Hardware: Other OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Holidays Assignee: koha-bugs@lists.koha-community.org Reporter: anke.bruns@gwdg.de QA Contact: testopia@bugs.koha-community.org If sample holidays are chosen in the onboarding tool, there is an error message: sample_libraries_holidays.yml DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_pks`.`repeatable_holidays`, CONSTRAINT `repeatable_holidays_ibfk_1` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/koha/lib/C4/Installer.pm line 575. This is probably due to the fact that at that stage no branches have yet been created for the instance. It would probably with sample branches chosen but it should work also without the sample branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It cannot work without the sample branches as every holiday needs to be connected to a library. They cannot be added without a library present in the database. The sample data is loaded before the onboarding process starts. I think the best we could probably do is maybe to lock/grey out the checkbox when the sample libraries are not selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Component|Holidays |Installation and upgrade | |(web-based installer) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #2 from Anke Bruns <anke.bruns@gwdg.de> --- Thanks for the explanation. The problem with sample branches is that there are quite a lot of them that are really cumbersome to remove later on. I would suggest either one of the following: - Reduce the number of sample branches to maybe one to three at most and explain in the web installer that they have to be checked for the sample holidays to function - change the order of the process so that people can add their own branch(es) before importing the sample holidays - just explain in the web installer that without the sample branches the sample holidays can't be imported, and give a hint how many sample branches there are so one knows what to expect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152083&action=edit Bug 33581: Disable sample holiday if libraries are not selected If libraries are not selected we should not try to insert holidays, or the installer will fail with a missing FK. This patch simply disable and uncheck the checkbox when libraries are not going to be inserted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |unspecified CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error in Webinstaller |Error in Webinstaller |concerning sample holidays |concerning sample holidays | |and patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error in Webinstaller |Error in Webinstaller |concerning sample holidays |concerning sample holidays |and patrons |and libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152083|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152142&action=edit Bug 33581: Disable sample holiday if libraries are not selected If libraries are not selected we should not try to insert holidays, or the installer will fail with a missing FK. This patch simply disable and uncheck the checkbox when libraries are not going to be inserted. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152143&action=edit Bug 33581: Add sample patrons to patch and some hints * Adds sample patrons to the new dependency checking JS * Adds a red "requires sample libraries" note to sample patrons and sample holidays, to make things more clear to users. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error in Webinstaller |Error in Webinstaller |concerning sample holidays |concerning sample holidays |and libraries |and patrons requiring | |sample libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks like this: https://snipboard.io/MRlWT6.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152142|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152188&action=edit Bug 33581: Disable sample holiday if libraries are not selected If libraries are not selected we should not try to insert holidays, or the installer will fail with a missing FK. This patch simply disable and uncheck the checkbox when libraries are not going to be inserted. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152143|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152189&action=edit Bug 33581: Add sample patrons to patch and some hints * Adds sample patrons to the new dependency checking JS * Adds a hind "requires sample libraries" to sample patrons and sample holidays. To test: * Build CSS (yarn build) * Veriy the checkbox for sample patrons works like the sample holidays one * Verify the hint shows up as intended Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error in Webinstaller |Error in web installer |concerning sample holidays |concerning sample holidays |and patrons requiring |and patrons requiring |sample libraries |sample libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152188|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153307&action=edit Bug 33581: Disable sample holiday if libraries are not selected If libraries are not selected we should not try to insert holidays, or the installer will fail with a missing FK. This patch simply disable and uncheck the checkbox when libraries are not going to be inserted. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152189|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153308&action=edit Bug 33581: Add sample patrons to patch and some hints * Adds sample patrons to the new dependency checking JS * Adds a hind "requires sample libraries" to sample patrons and sample holidays. To test: * Build CSS (yarn build) * Veriy the checkbox for sample patrons works like the sample holidays one * Verify the hint shows up as intended Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34337 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34337 [Bug 34337] No sample patrons anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I marked this report as the suspect for no longer creating sample patrons. Bug 34337 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org