[Bug 42329] New: Staff can check out to patrons with fines over NoIssuesCharge when AllowFineOverride set to Don't Allow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Bug ID: 42329 Summary: Staff can check out to patrons with fines over NoIssuesCharge when AllowFineOverride set to Don't Allow Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com To recreate: - add fines/fees to a patron account until they are over the limit set by the noissuescharge system preference - confirm AllowFineOverride is set to "Don't Allow" - log into Koha as a user with force_checkout permission (or a superlibrarian) - go to the account of your patron with fines - you are given a warning that the patron cannot check out and has charges on their account, but offered an "Override restriction temporarily" button - click "Override restriction temporarily" - check an item out to your patron successfully If AllowFineOverride is set to "Don't Allow," users should not be able to check out to patrons with fines over the noissuescharge amount, regardless of user permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I feel like this would be too big a change in behaviour. Currently, the force_checkouts permission is "if a limitation exists", which AllowFineOverride set to Don't Allow fall into. To me, it makes sense how it is currently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Walking through the different combinations of permission and system preference settings here: 1 - AllowFineOverride set to Don't allow, without force_checkout permission: Checkout blocked 2 - AllowFineOverride set to Don't allow, with force_checkout permission: Checkout allowed 3 - AllowFineOverride set to Allow, without force_checkout permission: Checkout blocked 4 - AllowFineOverride set to Allow, with force_checkout permission: Checkout allowed The value of the system preference is not actually changing anything beyond display -- setups 2 and 4 give different messaging to the user but allow the same behavior. If this is the desired behavior, the system preference should be removed. But my expectation is that AllowFineOverride will behave like AllowNotForLoanOverride and AllowTooManyOverride. That behavior is: 1 - AllowNotForLoanOverride set to Don't allow, without force_checkout permission: Checkout blocked 2 - AllowNotForLoanOverride set to Don't allow, with force_checkout permission: Checkout blocked 3 - AllowNotForLoanOverride set to Allow, without force_checkout permission: Checkout blocked 4 - AllowNotForLoanOverride set to Allow, with force_checkout permission: Checkout allowed The system preference dictates the extent of the permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 [Bug 35188] force_checkout permission can override all blocks on a patron account but only shows when they are restricted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Danielle M. <dmeininger591@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmeininger591@gmail.com --- Comment #3 from Danielle M. <dmeininger591@gmail.com> --- Consistency between 1. Allow Fine override 2. Allow Not for Loan override 3. Allow Too Many Override would be ideal. I think the force_checkout permission is for superlibrarians and the like. So if the three system preferences are set to "Don't Allow" but the staff member has force_checkout permission they can override it. So my read is that AllowFineOverride is actually working how it should and the other two are needing changed? Still noodling on it though... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m --- Comment #4 from Catrina Berka <catrina@bywatersolutions.com> --- I agree with Danielle that we should have consistency between these three system preferences. As Andrew describes, if the behavior is no different when the system preference is enabled or disabled, why does it exist in the first place? For that reason, I'd recommend what Andrew describes in the initial filing of this bug to create consistency between AllowFineOverride, AllowNotForLoanOverride, and AllowTooManyOverride. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- My memory here is that historically AllowFineOverride and force_checkout did match the behavior of AllowNotForLoanOverride -- the permission allows users to perform overrides as enabled by the syspref. It looks like that changed in 23.11 with Bug 35188. I've not been successful in getting a pre-23.11 version running on my test site to confirm this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I sort of feel like all those preferences should be tertiaries.. they're different types of block and thus blocking may be more or less strict. I was thinking a tertiary of 'Allow override with permissions', 'Allow override without permissions' and 'Never allow override'. But, actually.. is it likely one might actually want distinct permission rather than preferences? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org