[Bug 17550] New: Display additional patron data in patron suggestion form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Bug ID: 17550 Summary: Display additional patron data in patron suggestion form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: theod@lib.auth.gr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When in Home › Circulation › Checkouts and the librarian wants to select a patron to perform a checkout upon, the suggestions currently display only the following patron data: Surname, Firstname (CardNumber) Address City Zipcode Country It would be nice if patron INITIALS were also displayed, like this: Surname, Firstname INITIALS (CardNumber) Address City Zipcode Country The reason is that multiple patrons may have the same Surname and Firstname and in order to distinguish them the librarians feel better to ask the patron for their initials rather than asking for the address (btw in our installation we use Father's name in place of initials, but this doesn't alter the use case) Further more, to better distinguish the various names and to make the Surname and Firstname 'stand out', I suggest converting them to bold, while making the initials italic. For all these changes the patch (in matter of code lines) is trivial: a few lines in two files. You may also find two screenshots of the current and the proposed functionality (the screenshots were taken from a Koha 3.20.x server but the change is applicable to recent versions also and the patch is created using the current master) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #1 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Created attachment 57179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57179&action=edit Current functionality -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #2 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Created attachment 57180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57180&action=edit Proposed functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #3 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Created attachment 57181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57181&action=edit Patch to implement the desired enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #4 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Steps to reproduce: 1/ In the Koha staff interface, go to Home › Circulation › Checkouts (/cgi-bin/koha/circ/circulation.pl) 2/ Start typing an existing patron (last)name in the "Check Out" textarea 3/ Suggestions are provided without patron Initials being displayed With the patch applied, when following the above steps, Initials are displayed in italics and Lastname/Firstname are in bold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby@ilsleypubliclib | |rary.org --- Comment #5 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Created attachment 57663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57663&action=edit Error message on applying the patch Hi Theodorus, I get an error on applying this patch (see attached screenshot). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57181|0 |1 is obsolete| | --- Comment #6 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Created attachment 57672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57672&action=edit Patch to implement the desired enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #7 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- @Chris: You're probably right. I was lazy and created the old patch manually and tested it with 'patch -p1' (which worked). I now used git bz for the whole process, so it should be OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #8 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Hi Theodoros, I tested and now it seems to work. I am new to this, but it looks like the commit message may need updating per https://wiki.koha-community.org/wiki/Commit_messages. For example, the bug number description needs reformatting. And your test plan needs to be included. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #9 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Created attachment 57780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57780&action=edit Bug 17550: Display additional patron data in patron suggestion form When in Home > Circulation > Checkouts and the librarian wants to select a patron to perform a checkout upon, the suggestions currently display only the following patron data: Surname, Firstname (CardNumber) Address City Zipcode Country. It would be useful if patron INITIALS were also displayed, like this: Surname, Firstname INITIALS (CardNumber) Address City Zipcode Country To Test: 1) In the staff interface, /cgi-bin/koha/circ/circulation.pl, start typing an existing patron (last)name in the "Checkout" textarea. 2) Suggestions are provided, surname and firstname formatted as plain text, WITHOUT the patron Initials being displayed. 3) Apply the patch. 4) Repeat step 1. 5) Observe that the suggestions display surname and first name formatted in bold and the the Initials displayed in italics. Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57672|0 |1 is obsolete| | Attachment #57780|0 |1 is obsolete| | --- Comment #10 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Created attachment 57781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57781&action=edit Bug 17550: Display additional patron data in patron suggestion form When in Home > Circulation > Checkouts and the librarian wants to select a patron to perform a checkout upon, the suggestions currently display only the following patron data: Surname, Firstname (CardNumber) Address City Zipcode Country. It would be useful if patron INITIALS were also displayed, like this: Surname, Firstname INITIALS (CardNumber) Address City Zipcode Country To Test: 1) In the staff interface, /cgi-bin/koha/circ/circulation.pl, start typing an existing patron (last)name in the "Checkout" textarea. 2) Suggestions are provided, surname and firstname formatted as plain text, WITHOUT the patron Initials being displayed. 3) Apply the patch. 4) Repeat step 1. 5) Observe that the suggestions display surname and first name formatted in bold and the the Initials displayed in italics. Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #11 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Thanks Kris for your help. I'm also fairly new to this, so all feedback is welcome! ps1. I was about to write a simple test plan today, but you got me :) Let's hope it will now get a better chance of passing QA... ps2. As for my frugal commit message body, I would have gladly put more details, but I thought it would be in vain, as it seems the Koha team uses git as a repo only and Bugzilla for everything else. Having said that, I'll try to be more descriptive next time! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #12 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- (Typo fix: Chris, not Kris! Early Monday morning and no coffee=disaster) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57663|Error message on applying |Error message on applying description|the patch |the patch (now obsolete, | |referred to older patch) Attachment #57663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Theodoros, do you want me to change the name and email address used in the patch? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This value is not used anywhere else, why do you want to display it there? To me it's not consistent to display the initials in only one place, I guess the problem is the same on the other patron search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |theod@lib.auth.gr |ity.org | Status|Signed Off |ASSIGNED --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #13)
Theodoros, do you want me to change the name and email address used in the patch?
(In reply to Jonathan Druart from comment #14)
This value is not used anywhere else, why do you want to display it there? To me it's not consistent to display the initials in only one place, I guess the problem is the same on the other patron search results.
Waiting for answers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #16 from Theodoros Theodoropoulos <theod@lib.auth.gr> ---
Theodoros, do you want me to change the name and email address used in the patch? Hmmm... What is the common practice? To use the github (ie almost 'dummy') email or the bugzilla one?
This value is not used anywhere else, why do you want to display it there? To me it's not consistent to display the initials in only one place, I guess the problem is the same on the other patron search results. Well, this is the no.1 place where our librarians search manually for patrons to quickly check-out books to (if they don't have their library card with the barcode with them). If they manage to choose the proper patron from this screen (by verifying also the patron Initials -or the Father's name) they avoid unnecessary clicks and possibly-wrong checkouts. The initials are also displayed in the Patron Details screen, so it's not 'only' there... That said, indeed it would be better if this "Initials" information was concatenated in the "Name" column of the patron result list, but I suppose this would be a big change in Koha behavior and should(?) be documented... If, however, you consider that approach to be more consistent, I'll take a look and see how it could be done.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display additional patron |Display initials in patron |data in patron suggestion |search autocomplete |form | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm that the inititals and other new/old name fields are currently not shown in the autocomplete. They also not show as part of the long name form in the patron account, but only in the labeled field. I believe we should not just keep adding to the display. Maybe with all the new fields added to the patron form (alias, middle name and soon also preferred name?) we might want to make this configurable? For the email address. The patches have: From: sbujam <sbujam@users.noreply.github.com> The mail address and name will be used to create the release notes and to show your name on the dashboard. We don't ask for a specific email address, but it should be the one you use. Same for the name: it should be the one you want to have displayed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org