[Bug 43739] New: Each notice template should only be shown once in reports Run With Template dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Bug ID: 43739 Summary: Each notice template should only be shown once in reports Run With Template dropdown Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com Depends on: 34136 Target Milestone: --- When a notice template in the Reports module has content in more than one format, the template name is listed multiple times in the "Run with template" dropdown when running a report. To recreate: - Create a new notice template: -- module: Reports -- name: Test - Add a message subject and some content in the Email format - Add a message subject and some content in the Print format (the actual content is irrelevant, it could just be "email" and "print") - Create a report (again, content doesn't matter, can be "SELECT 'boop'") - Click "Run with template" - See the dropdown shows "Test" twice - See both entries link to "/cgi-bin/koha/reports/guided_reports.pl?id=1&op=run&template_code=Test" - Confirm both options have the same result when clicked Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- See discussion on Bug 42736 - prior to 26.05, reports could use a template in any format (email, print, SMS), so it was meaningful to offer all available formats. If we return to allowing any format to be used, then this bug is moot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Comma delimited| |Open Fifth list of Sponsors| | Sponsorship status|--- |Sponsored Depends on| |43736 Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43736 [Bug 43736] Reports should use the Print format when rendering with a template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 --- Comment #2 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 207384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207384&action=edit Bug 43739: Disambiguate report templates by transport type As the report template dropdown offers each message transport type for a give notice, this can lead to duplicate entries with no way to tell them apart. This patch disambiguates each entry by appending the transport type. Test plan: 1. Ensure Bug 43736 is already applied. 2. Under Tools > Notices and Slips, create a new notice in the Reports module. Choose a code and a name, and add distinct subjects and contents for both Email and Print. For example, "Email: [% today %]" and "Print: [% today %]". 3. Under Reports, create a new report from SQL with a name and the following query: SELECT 1; 4. Open the "Run with template" dropdown for the report, and verify you see the name of your created notice twice, with no way to distinguish them. 5. Apply patch and refresh. 6. Open the "Run with template" dropdown for the report, and verify you see the name of your created notice twice, each also including their transport type. 7. Verify that running each template version produces the correct corresponding output for its transport type. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Each notice template should |Notice templates should |only be shown once in |include format with notice |reports Run With Template |name in dropdown |dropdown | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207403&action=edit Bug 43739: Disambiguate report templates by transport type As the report template dropdown offers each message transport type for a give notice, this can lead to duplicate entries with no way to tell them apart. This patch disambiguates each entry by appending the transport type. Test plan: 1. Ensure Bug 43736 is already applied. 2. Under Tools > Notices and Slips, create a new notice in the Reports module. Choose a code and a name, and add distinct subjects and contents for both Email and Print. For example, "Email: [% today %]" and "Print: [% today %]". 3. Under Reports, create a new report from SQL with a name and the following query: SELECT 1; 4. Open the "Run with template" dropdown for the report, and verify you see the name of your created notice twice, with no way to distinguish them. 5. Apply patch and refresh. 6. Open the "Run with template" dropdown for the report, and verify you see the name of your created notice twice, each also including their transport type. 7. Verify that running each template version produces the correct corresponding output for its transport type. Sponsored-by: Open Fifth Signed-off-by: Barbara Johnson <Barbara.Johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43739 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207405&action=edit Bug 43739: Disambiguate report templates by transport type As the report template dropdown offers each message transport type for a give notice, this can lead to duplicate entries with no way to tell them apart. This patch disambiguates each entry by appending the transport type. Test plan: 1. Ensure Bug 43736 is already applied. 2. Under Tools > Notices and Slips, create a new notice in the Reports module. Choose a code and a name, and add distinct subjects and contents for both Email and Print. For example, "Email: [% today %]" and "Print: [% today %]". 3. Under Reports, create a new report from SQL with a name and the following query: SELECT 1; 4. Open the "Run with template" dropdown for the report, and verify you see the name of your created notice twice, with no way to distinguish them. 5. Apply patch and refresh. 6. Open the "Run with template" dropdown for the report, and verify you see the name of your created notice twice, each also including their transport type. 7. Verify that running each template version produces the correct corresponding output for its transport type. Sponsored-by: Open Fifth Signed-off-by: Barbara Johnson <Barbara.Johnson@bedfordtx.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org