[Bug 39717] New: Stock rotation stages cannot be moved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Bug ID: 39717 Summary: Stock rotation stages cannot be moved Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In the routine Koha::StockRotationStage->move_to we are doing a stringwise comparison of the position to move to, versus the count of stages This works when we have a limited number of stages, but fails when we have many: perl -e 'warn "Yes" if "3" le "26"' It's not. Changing to <= seems to fix this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181395&action=edit Bug 39717: Use numeric comparison for stock rotation stages To test: 1 - Enable SotckRotation http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=StockRotation 2 - Browse to "Cataloging -> StockRotation" 3 - 'New rota' - fill out the form and save 4 - Manage->stages 5 - Add many stages, more than 10 at least 6 - Try to move a stage form the bottom to position 3 7 - Note message above list: Saving changes... Error: Bad Request 8 - Apply patch, restart_all 9 - Attempt to move stages, try many combinations 10 - Success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181395|0 |1 is obsolete| | --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 181396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181396&action=edit Bug 39717: Use numeric comparison for stock rotation stages To test: 1 - Enable SotckRotation http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=StockRotation 2 - Browse to "Cataloging -> StockRotation" 3 - 'New rota' - fill out the form and save 4 - Manage->stages 5 - Add many stages, more than 10 at least 6 - Try to move a stage form the bottom to position 3 7 - Note message above list: Saving changes... Error: Bad Request 8 - Apply patch, restart_all 9 - Attempt to move stages, try many combinations 10 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Self SO, moving to QA, this is pretty straightforward -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181396|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181401&action=edit Bug 39717: Use numeric comparison for stock rotation stages To test: 1 - Enable SotckRotation http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=StockRotation 2 - Browse to "Cataloging -> StockRotation" 3 - 'New rota' - fill out the form and save 4 - Manage->stages 5 - Add many stages, more than 10 at least 6 - Try to move a stage form the bottom to position 3 7 - Note message above list: Saving changes... Error: Bad Request 8 - Apply patch, restart_all 9 - Attempt to move stages, try many combinations 10 - Success! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Oops.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39717 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org