[Bug 9822] New: No alert appears on adding an order to a basket if the budget has exceeded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Bug ID: 9822 Summary: No alert appears on adding an order to a basket if the budget has exceeded Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16160&action=edit Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch Depends on| |4266 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 1822 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |koha@univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I create a new fund with warning fields (% and amount). I try all the combinations : the appropriate warning message appears. If you don't confirm the command, there's no problem. But, if you choose to confirm the command, there's a error " Software error: Tag "" is not a valid tag. at /usr/share/perl5/MARC/File/SAX.pm line 92" When I go back to the basket, the line is well recorded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16160|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16257&action=edit Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16257|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16261&action=edit Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- ok, everything works fine this time ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16261|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16314&action=edit Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16314|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19092&action=edit Bug 9822: Alert on adding an order to a basket if budget has exceeded 2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend. This patch uses these fields in order to show a warning message if the budget selected for an order has exceeded. Test plan: - Create a new active fund with at least 1 of both warning fields ('Warning at (%)' and 'Warning at (amount)'). - Create a new order for a basket with this new fund and a cost > warning amount defined for the fund (or using %). - Save and check that a warning message appears - Retry playing with all combinations of warning fields Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime@gmail.com --- Comment #10 from simith.doliveira@inlibro.com --- *** Bug 6832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org