[Bug 32041] New: OPAC and staff client results page do not honor SyndeticsCoverImageSize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Bug ID: 32041 Summary: OPAC and staff client results page do not honor SyndeticsCoverImageSize Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The SyndeticsCoverImageSize system preference claims "Cover images from Syndetics on search results and item detail pages in the OPAC and the staff interface in a "medium/large" size. Adjusting this system preference does not change the image size of the OPAC results page or staff client results page. Either the description of the system preference should be altered or the results pages should be made to honor the system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I think this is being handled correctly, the results pages should always show the smaller thumbnail type images. The system preference description should be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I've had many libraries complain about the small size/blurriness of cover images on the results page. We should make Syndetics cover images honor the 'SyndeticsCoverImageSize' in any place where they are displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149388&action=edit Bug 32041: Enforce SyndeticsCoverImageSize everywhere This patch add the SyndeticsCoverImageSize to the folling pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt To test: 1. Turn on SyndeticsCoverImages and SyndeticsEnabled. 2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize. 3. Check the OPAC results page. 4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser. 5. Test the OPAC checkout history page. ( opac-readingrecord.tt ) 6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Everything about the patch worked great except for step #4. Even though I had OPACShelfBrowser turned on I could never find any records in the OPAC that would display the shelf browser so I couldn't test that part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Barbara Johnson from comment #4)
Everything about the patch worked great except for step #4. Even though I had OPACShelfBrowser turned on I could never find any records in the OPAC that would display the shelf browser so I couldn't test that part.
Did your items have an item.itemcallnumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #6 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- They did not. Let me add that and try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #7 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- That worked. The images do appear in the correct sizes in the shelf browser. However, when scrolling back and forth through the titles in the shelf browser, once I go back to look at the original images they now display the ‘No cover image available’ graphic instead of the cover images. It doesn’t seem to be holding on to the images. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Barbara Johnson from comment #7)
That worked. The images do appear in the correct sizes in the shelf browser. However, when scrolling back and forth through the titles in the shelf browser, once I go back to look at the original images they now display the ‘No cover image available’ graphic instead of the cover images. It doesn’t seem to be holding on to the images.
Is that behavior that you can recreate with or without this patch? If so, perhaps we should file a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #9 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I’m not sure. Is there a way to un-apply a patch on a sandbox? Or do I need to start from scratch with a new one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Barbara Johnson from comment #9)
I’m not sure. Is there a way to un-apply a patch on a sandbox? Or do I need to start from scratch with a new one?
You can't remove the patch, but you can make another sandbox without entering a bug number to get an installation without any chances for comparison. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149759&action=edit Bug 33168: (follow-up) Swap spaces for tabs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I retested and can confirm that the images not being retained when scrolling through the shelf browser exists without this patch. It has already been filed as bug 29993. Everything else about this patch works great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Barbara Johnson from comment #12)
I retested and can confirm that the images not being retained when scrolling through the shelf browser exists without this patch. It has already been filed as bug 29993. Everything else about this patch works great.
Thanks Barbara, I have also added a patch for Bug 29993. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trusting Barbara and Lucas here for testing with Syndetics credentials. I have carefully reviewed the patch and compared it to how other syndetics file names were built previously and it all appears to match up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149388|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150140&action=edit Bug 32041: Enforce SyndeticsCoverImageSize everywhere This patch add the SyndeticsCoverImageSize to the folling pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt To test: 1. Turn on SyndeticsCoverImages and SyndeticsEnabled. 2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize. 3. Check the OPAC results page. 4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser. 5. Test the OPAC checkout history page. ( opac-readingrecord.tt ) 6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt ) Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #17 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |arthur.suzuki@biblibre.com --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- doesn't apply on 21.11 please provide a backport if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC and staff client |OPAC and staff interface |results page do not honor |results page do not honor |SyndeticsCoverImageSize |SyndeticsCoverImageSize -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org