[Bug 42860] New: UNIVERSAL::require is deprecated and should be replaced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 Bug ID: 42860 Summary: UNIVERSAL::require is deprecated and should be replaced Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- UNIVERSAL::require is used only for the SIP server and nowhere else. We should be able to replace it with Module::Load which is already used in Koha elsewhere. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42847 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200546&action=edit Bug 42860: Replace UNIVERSAL::require with Module::Load::Conditional UNIVERSAL::require is deprecated. It is used only by the SIP server, to load the configured ILS implementation module in login_core(). Module::Load::Conditional is already a Koha dependency and is used elsewhere in Koha, so we can use can_load() instead and drop UNIVERSAL::require from the dependency lists. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/MsgType.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Note: Access to dependent bug 42847 is restricted, so need to be on the security team to test this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42860 Bug 42860 depends on bug 42847, which changed state. Bug 42847 Summary: SIP authentication ignored after initial successful connection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42847 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org