https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56624&action=edit Bug 17453: Inter-site holds improvement At the moment users can reserve items and choose any library as a pick up location, but there is no mechanism to prevent users from reserving items that are available on the shelf at any given location from reserving the item at the same location, essentially creating a Fetch and Collect scenario. This has an impact on staff workloads as they are having to process reservations and check shelves for items that students can already come and collect from the open library shelves. The aim of this enhancement is to decrease the impact on staff workload there should be a restriction in place that prevents users from requesting items for collection at a library where the item is currently available. Implementation: We first tried to add a new circulation rule adding a 4th “NotIfAvailableAtPickupLibrary” option to "On shelf holds allowed". That would make the development more flexible. But in that case we quickly faced non-trivial problematics: Let's say you have 3 items I1, I2 and I3. The first one has onshelfholds set to Yes and 2 others has it set to “NotIfAvailableAtPickupLibrary”. What would be the expected behavior if a hold is placed at biblio level? And if a hold is placed at item level for I1? This second point could be answered by reworking the interface to move the libraries dropdown list elsewhere (1 list per item) or by adding a lot of JS code to handle the different situation. But it would be much more complicated to implement. So finally I moved back to the simple approach and added a new pref to handle the behavior globally. Test plan: 0/ Switch off OPACHoldsIfAvailableAtPickup 1/ Let's say you have 3 libraries L1, L2, L3, create 2 items owned by L1 and L2 2/ Place a biblio level hold. You should only be able to pick it up at L3 2/ Place a item level hold. You should only be able to pick it up at L3 3/ Create a third items owned by L3 4/ Now you should not be able to place a hold on this record anymore Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)

We can imagine another syspref to list the patron categories not affected by this behaviour.

Or a flag in the (patron) categories table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Janet McGowan <janet.mcgowan@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 57003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57003&action=edit Bug 17453: Inter-site holds improvement At the moment users can reserve items and choose any library as a pick up location, but there is no mechanism to prevent users from reserving items that are available on the shelf at any given location from reserving the item at the same location, essentially creating a Fetch and Collect scenario. This has an impact on staff workloads as they are having to process reservations and check shelves for items that students can already come and collect from the open library shelves. The aim of this enhancement is to decrease the impact on staff workload there should be a restriction in place that prevents users from requesting items for collection at a library where the item is currently available. Implementation: We first tried to add a new circulation rule adding a 4th “NotIfAvailableAtPickupLibrary” option to "On shelf holds allowed". That would make the development more flexible. But in that case we quickly faced non-trivial problematics: Let's say you have 3 items I1, I2 and I3. The first one has onshelfholds set to Yes and 2 others has it set to “NotIfAvailableAtPickupLibrary”. What would be the expected behavior if a hold is placed at biblio level? And if a hold is placed at item level for I1? This second point could be answered by reworking the interface to move the libraries dropdown list elsewhere (1 list per item) or by adding a lot of JS code to handle the different situation. But it would be much more complicated to implement. So finally I moved back to the simple approach and added a new pref to handle the behavior globally. Test plan: 0/ Switch off OPACHoldsIfAvailableAtPickup 1/ Let's say you have 3 libraries L1, L2, L3, create 2 items owned by L1 and L2 2/ Place a biblio level hold. You should only be able to pick it up at L3 2/ Place a item level hold. You should only be able to pick it up at L3 3/ Create a third items owned by L3 4/ Now you should not be able to place a hold on this record anymore Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 57005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57005&action=edit Bug 17453: Allow pickup at a library where all items are checked out If all items are checked out then it should be possible to select the pickup library for that record. Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Patch doesn't apply, I also wonder about last patch: Allow pickup at a library where all items are checked out It only checks if items are checked out, but what about case of items waiting for pickup or damaged/lost? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57005|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59916&action=edit Bug 17453: Allow pickup at a library where all items are checked out If all items are checked out then it should be possible to select the pickup library for that record. Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Chatted with Claire in IRD, I think this needs some sort of visible notification to patron to explain why the hold locations are disabled (the hover notification is appreciated but not sufficient I think) <kidclamp> Would you agree to some sort of notification that this pref is active to explain why the location is disabled? <LibraryClaire> my original plan said for there to be a message that says item is availabel for collection at that library <LibraryClaire> or similar when they go to place the reservation <kidclamp> "Note: Library policy does not allow hold/pickup of an item avialable locally. Please come to the library to retrieve these items" <LibraryClaire> along those lines <kidclamp> yeah or what you said, okay I will post that for Joubu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #18 from Claire Gravely <claire_gravely@hotmail.com> --- (In reply to Jonathan Druart from comment #15)

(In reply to Nick Clemens from comment #12)

...

Patch doesn't apply, I also wonder about last patch: Allow pickup at a library where all items are checked out

It only checks if items are checked out, but what about case of items waiting for pickup or damaged/lost?

Hum yes you may be right. But that sounds like a very specific situation and that would make the code much complicated. I'd suggest to go first with these patches and improve them later if it is really needed. If you think it has to be handled, I can try and provide a patch on this bug report.

I would agree with Nick that items that are on hold for someone or otherwise marked as unavailable ( such as lost) should be taken into consideration. No items should be "available" at the pick up location in order for it to qualify as a pick up location perhaps? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60286&action=edit Bug 17453: Inter-site holds improvement At the moment users can reserve items and choose any library as a pick up location, but there is no mechanism to prevent users from reserving items that are available on the shelf at any given location from reserving the item at the same location, essentially creating a Fetch and Collect scenario. This has an impact on staff workloads as they are having to process reservations and check shelves for items that students can already come and collect from the open library shelves. The aim of this enhancement is to decrease the impact on staff workload there should be a restriction in place that prevents users from requesting items for collection at a library where the item is currently available. Implementation: We first tried to add a new circulation rule adding a 4th “NotIfAvailableAtPickupLibrary” option to "On shelf holds allowed". That would make the development more flexible. But in that case we quickly faced non-trivial problematics: Let's say you have 3 items I1, I2 and I3. The first one has onshelfholds set to Yes and 2 others has it set to “NotIfAvailableAtPickupLibrary”. What would be the expected behavior if a hold is placed at biblio level? And if a hold is placed at item level for I1? This second point could be answered by reworking the interface to move the libraries dropdown list elsewhere (1 list per item) or by adding a lot of JS code to handle the different situation. But it would be much more complicated to implement. So finally I moved back to the simple approach and added a new pref to handle the behavior globally. Test plan: 0/ Switch off OPACHoldsIfAvailableAtPickup 1/ Let's say you have 3 libraries L1, L2, L3, create 2 items owned by L1 and L2 2/ Place a biblio level hold. You should only be able to pick it up at L3 2/ Place a item level hold. You should only be able to pick it up at L3 3/ Create a third items owned by L3 4/ Now you should not be able to place a hold on this record anymore Sponsored-by: University of the Arts London Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=14753 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60288&action=edit Bug 17453: Allow pickup at a library where all items are checked out If all items are checked out then it should be possible to select the pickup library for that record. Signed-off-by: Janet McGowan <janet.mcgowan@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=14753 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60290&action=edit Bug 17453: Take into account items that are lost or damaged If all the items are either lost, damaged or checked out, then pickup should be allowed. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=14753 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- I am not 100% sure on the wording of the message, but I don't have a better suggestion and feature works as advertised -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |At the moment users can release notes| |reserve items and choose | |any library as a pick up | |location, but there is no | |mechanism to prevent users | |from reserving items that | |are available on the shelf | |at any given location from | |reserving the item at the | |same location, essentially | |creating a Fetch and | |Collect scenario. | |This has | |an impact on staff | |workloads as they are | |having to process | |reservations and check | |shelves for items that | |students can already come | |and collect from the open | |library shelves. | |The aim of | |this enhancement is to | |decrease the impact on | |staff workload there | |should | |be a restriction in place | |that prevents users from | |requesting items for | |collection at a library | |where the item is currently | |available. CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024 [Bug 25024] OPAC incorrectly marks branch as invalid pickup location when similarly named branch is blocked -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #31)

A bit late, but what about the pref description: Do not allow to pickup holds at libraries where the item is available.

Isnt this confusing? This is not about picking up, this is about placing holds.

So I would prefer to say: Do not allow to place holds at libraries where the item is available.

And then there also is On shelf holds allowed in the circ matrix. It feels like this pref should be part of that somehow..

I think a separate bug would be in order :) But for what it's worth, I'd make sure we still include 'pick-up location' in the description. What's going on here influences the list of pick-up locations and that's something people might search for. -- You are receiving this mail because: You are watching all bug changes.