[Bug 42440] New: Remove event attributes from labeled MARC detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Bug ID: 42440 Summary: Remove event attributes from labeled MARC detail template Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 38407 catalogue/labeledMARCdetail.tt has an "onChange" event attribute which is redundant. There's already a version of that event handler in the JS block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197984&action=edit Bug 42440: Remove event attributes from labeled MARC detail template This patch removes a redundant "onchange" event attribute from the framework selection dropdown. This event is already registered in the JS block. The patch also does a little bit of cleanup to the JS: Combining two <script> tags which don't need to be separate and moving a function outside of the $(document).ready block. To test, apply the patch and search for a bibliographic record in the catalog. - From the detail page, click the "Labeled MARC" tag in the sidebar (you may need to enable the "viewLabeledMARC" preference). - Try changing the "With framework" selection. The page should reload with the selected framework. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 198073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198073&action=edit Bug 42440: Remove event attributes from labeled MARC detail template This patch removes a redundant "onchange" event attribute from the framework selection dropdown. This event is already registered in the JS block. The patch also does a little bit of cleanup to the JS: Combining two <script> tags which don't need to be separate and moving a function outside of the $(document).ready block. To test, apply the patch and search for a bibliographic record in the catalog. - From the detail page, click the "Labeled MARC" tag in the sidebar (you may need to enable the "viewLabeledMARC" preference). - Try changing the "With framework" selection. The page should reload with the selected framework. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198600&action=edit Bug 42440: Remove event attributes from labeled MARC detail template This patch removes a redundant "onchange" event attribute from the framework selection dropdown. This event is already registered in the JS block. The patch also does a little bit of cleanup to the JS: Combining two <script> tags which don't need to be separate and moving a function outside of the $(document).ready block. To test, apply the patch and search for a bibliographic record in the catalog. - From the detail page, click the "Labeled MARC" tag in the sidebar (you may need to enable the "viewLabeledMARC" preference). - Try changing the "With framework" selection. The page should reload with the selected framework. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42282 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Rebased on top of bug 42282. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 [Bug 42282] Tidy all script tags - catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Bug 42440 depends on bug 42282, which changed state. Bug 42282 Summary: Tidy all script tags - catalogue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42282 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 26.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org