https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197984&action=edit Bug 42440: Remove event attributes from labeled MARC detail template This patch removes a redundant "onchange" event attribute from the framework selection dropdown. This event is already registered in the JS block. The patch also does a little bit of cleanup to the JS: Combining two <script> tags which don't need to be separate and moving a function outside of the $(document).ready block. To test, apply the patch and search for a bibliographic record in the catalog. - From the detail page, click the "Labeled MARC" tag in the sidebar (you may need to enable the "viewLabeledMARC" preference). - Try changing the "With framework" selection. The page should reload with the selected framework. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198600&action=edit Bug 42440: Remove event attributes from labeled MARC detail template This patch removes a redundant "onchange" event attribute from the framework selection dropdown. This event is already registered in the JS block. The patch also does a little bit of cleanup to the JS: Combining two <script> tags which don't need to be separate and moving a function outside of the $(document).ready block. To test, apply the patch and search for a bibliographic record in the catalog. - From the detail page, click the "Labeled MARC" tag in the sidebar (you may need to enable the "viewLabeledMARC" preference). - Try changing the "With framework" selection. The page should reload with the selected framework. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42440 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.