[Bug 21650] New: C4::Items::GetLastAcquisitions has never been used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Bug ID: 21650 Summary: C4::Items::GetLastAcquisitions has never been used and should be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81082&action=edit Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- POD Coverage failure. Otherwise Ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81082|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 81083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81083&action=edit Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results NOTE: POD Coverage test failure is expected on removal Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81083|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81291&action=edit Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results NOTE: POD Coverage test failure is expected on removal Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87398&action=edit Bug 21659: Change link to basket group edit page I have taken another look at other links like the one from acq order search and changed the link to not lead to the vendor's basket group page but to the edit page of the invidividual basket group. To test: - Same as first patch, verify links now lead to the basket grou edit page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87398|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 87398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87398 Bug 21659: Change link to basket group edit page Wrong bug number! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org