[Bug 38190] New: JS error on suggestion page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Bug ID: 38190 Summary: JS error on suggestion page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 34608 Uncaught SyntaxError: redeclaration of const av_bsort1 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 [Bug 34608] Add sort1 and sort2 to patron search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate Severity|enhancement |major Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172846&action=edit Bug 38190: Remove JS error on suggestion page This code could appear several time as we include it in modals Test plan: Go on http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl Open the console Notice that without this patch you see a JS error Uncaught SyntaxError: redeclaration of const av_bsort1 With this patch applied the error is gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38191 [Bug 38191] Suggestions filters do not expand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172846|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 172848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172848&action=edit Bug 38190: Remove JS error on suggestion page This code could appear several time as we include it in modals Test plan: Go on http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl Open the console Notice that without this patch you see a JS error Uncaught SyntaxError: redeclaration of const av_bsort1 With this patch applied the error is gone. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 38182 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172848|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172925&action=edit Bug 38190: Remove JS error on suggestion page This code could appear several time as we include it in modals Test plan: Go on http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl Open the console Notice that without this patch you see a JS error Uncaught SyntaxError: redeclaration of const av_bsort1 With this patch applied the error is gone. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Bug 38190 depends on bug 34608, which changed state. Bug 34608 Summary: Add sort1 and sort2 to patron search results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Bug 38190 depends on bug 34608, which changed state. Bug 34608 Summary: Add sort1 and sort2 to patron search results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Missing 24.05.x deps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38190 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41545 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org