http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-29 14:03:00 UTC --- I wondered if this paragraph was deleted by accicdent, because it seems not related to the patch description: [...] - - # can place hold on item ? - if ((!$item->{damaged} || C4::Context->preference('AllowHoldsOnDamagedItems')) - && !$item->{itemlost} - && !$item->{withdrawn} - ) { - $can_place_holds = 1; - } - $other_count++; [...] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 --- Comment #4 from Peter Lorimer <peter.lorimer@gmail.com> 2011-06-29 15:01:36 UTC --- Created attachment 4529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4529 Updated Patch File Z39.50 ISBN Field Populate Updated patch File: Now uses Business::ISBN to validate the ISBN and removes the user defined function validate_isbn() -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-30 06:07:05 UTC --- Hi Peter, thx for your work on this. I have one more concern: + my $bsth; + if ( C4::Context->preference("searchMyLibraryOnly") ) + { + $bsth =$dbh->prepare("SELECT branchcode,branchname FROM branches WHERE branchcode = '". C4::Branch::mybranch() ."' "); # FIXME : use C4::Branch::GetBranches + } + else + { + $bsth =$dbh->prepare("SELECT branchcode,branchname FROM branches "); + } This adds a check for a new system preference 'searchMyLibraryOnly' that is currently not existing in Koha (hope I didn't miss it). If this is something you want to contribute to Koha it should go on a different bug with more code to add the system preference properly and with a description what it is supposed to do, so that it can be documented. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4539|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-17 12:06:50 UTC --- Created attachment 4643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4643 [SIGNED-OFF] When searching the catalogue, if I get no results then hit the Z39.50 search the title field in the pop up window is populated with what I searched for. If I search for a valid ISBN number and hit the Z39.50 search, the title field is populated with the ISBN number I searched for. This number should populate the ISBN field and not the title field. http://bugs.koha-community.org/show_bug.cgi?id=6539 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: - Search new ISBN using ISBN search from advanced search page - 0 results - click on Z39.50 search - Z30.50 form will have your ISBN in ISBN search option I am signing off on this, because it's an improvement over the current behaviour. I see some problems though that should perhaps be addressed in a separate bug or as a follow-up: If you use th catalog search field and search for an ISBN or a keyword the right fields of the Z39.50 search form will be populated, but the search index will be put in front: ISBN: kw,wrdl: 9783492251495 or Title: kw,wrdl: koha testing If you search for ISBN as keyword on the advanced search page, it will still populate the Title search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 11:55:37 UTC --- Sorry for being long to QA, but I've to mark "failed QA" because there are many lines that are unrelated to the goal of the patch. Those lines should not harm, but I think they should be removed from the patch: For example : - my $bsth =$dbh->prepare("SELECT branchcode,branchname FROM branches"); # FIXME : use C4::Branch::GetBranches + my $bsth =$dbh->prepare("SELECT branchcode,branchname FROM branches "); - # item is withdrawn, lost, damaged, not for loan, reserved or in transit + # item is withdrawn, lost or damaged - - # can place hold on item ? + + # can place hold on item ? An many: + (empty line added) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |wizzyrea@gmail.com --- Comment #11 from Liz Rea <wizzyrea@gmail.com> 2012-01-24 23:13:53 UTC --- I ought to add, that I cleaned up the patch per Paul's desire. Please QA again? I didn't touch the meat of it, only the whitespace/weird comment changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA Version|rel_3_4 |rel_3_6 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 16:50:40 UTC --- QA comment: * a minor mistake in indentation, i've added a follow-up before pushing, just with indentation fixed * small patch passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 --- Comment #14 from Liz Rea <wizzyrea@gmail.com> 2012-02-02 05:20:34 UTC --- Also, this getting pushed means Peter gets added to the history! YAY! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6539 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.