[Bug 18931] New: Add a "data corrupted" section on the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Bug ID: 18931 Summary: Add a "data corrupted" section on the about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org If MySQL AUTO_INCREMENT messed ids (See https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix), we should add a warning on the about page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18003, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18651 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65010&action=edit Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966 [Bug 18966] Move of checkouts - Deal with duplicate IDs at DBMS level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65157&action=edit [16.05.x] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Looks good at a glance. I'll take another look at this once I've reviewed the other related bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Looks like I need to attend to other things at the moment, but I was just thinking... could you actually put this check into a module instead of on the about.pl page? That way, administrators on the server could perhaps run a script to check all their Koha instances for this data problem easily and quickly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Hugo Agud <hagud@orex.es> --- Good morning I tried to apply this patch but get this error CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Failed to merge in the changes. Patch failed at 0001 Bug 18931: Add a "data corrupted" section on the about page - MySQL AI The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/1605x-Bug-18931-Add-a-data-corrupted-section-on-th-WHdTUz.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65010|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65188&action=edit Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65188|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65189&action=edit Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- My only suggestion is maybe it should stand out more? Maybe giant, red and blinking? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65010|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- First patch applies nicely for me on 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65209&action=edit Bug 18931: Add items/deleteditems tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65210&action=edit [SIGNED OFF] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65211&action=edit [SIGNED OFF] Bug 18931: Add items/deleteditems tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65212&action=edit Bug 18931 - Follow up - Typo fix in SQL statement Fixes the table alias in the SQL statement for items and adds items to the if clause for showing data problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65010|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches tested on 16.11.x successfully. Added a follow-up to fix some minor glitches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65157|0 |1 is obsolete| | --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65255&action=edit [16.05.x] Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65211|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65256&action=edit Bug 18931: Add items/deleteditems tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65212|0 |1 is obsolete| | --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65257&action=edit Bug 18931 - Follow up - Typo fix in SQL statement Fixes the table alias in the SQL statement for items and adds items to the if clause for showing data problems. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65258&action=edit Bug 18931: (followup) Tidy text Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65210|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65259&action=edit Bug 18931: Add a "data corrupted" section on the about page - MySQL AI See the following wiki page for more information https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Test plan: Create (at least) a patron, a checkout, a biblio and a hold Then fill the old_* or deleted* tables with: INSERT INTO deletedborrowers SELECT * from borrowers WHERE borrowernumber=XXX; INSERT INTO deletedbiblio SELECT * from biblio WHERE biblionumber=XXX; INSERT INTO old_issues SELECT * from issues WHERE issue_id=XXX; INSERT INTO old_reserves SELECT * from reserves WHERE reserve_id=XXX; Go to the about page, 'System information' tab. You should see a new "Data problems" section with the list of the ids that are wrong Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65258|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65260&action=edit Bug 18931: (followup) Tidy text Some minor style and idiomatic issues. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #21 from Mason James <mtj@kohaaloha.com> --- Created attachment 65266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65266&action=edit Bug 18931 - Follow up - Typo fix in template for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #22 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #21)
Created attachment 65266 [details] [review] Bug 18931 - Follow up - Typo fix in template for holds
Ive tested this patchset on 16.05.x, it looks to be working well :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- Created attachment 65267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65267&action=edit pic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02. Nice work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65299&action=edit Bug 18931: [QA Follow-up] Fix typo in closing p tag for items Close the p tag and add a br tag to visually divide the two sections Data problems and Warnings regarding system configuration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Discovered the problem when testing a duplicate key in deleteditems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19000 [Bug 19000] about page - Typo in closing p tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65299|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 65299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65299 Bug 18931: [QA Follow-up] Fix typo in closing p tag for items Moved to bug 19000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #29 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 [Bug 19274] Translatability: Fix new splitting problems related to database warnings -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org