https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67705|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67781&action=edit Bug 19422 - Missing DROP TABLES in kohastructure.sql Adds DROP TABLE statements to the following tables - article_requests - biblio_metadata - deletedbiblio_metadata Test plan : Clean your database by running 'mysql < kohastructure.sql'. Without patch you'll get error messages. With patch everything will work fine, no warnings. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67781|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68051&action=edit Bug 19422 - Missing DROP TABLES in kohastructure.sql Adds DROP TABLE statements to the following tables - article_requests - biblio_metadata - deletedbiblio_metadata Test plan : Clean your database by running 'mysql < kohastructure.sql'. Without patch you'll get error messages. With patch everything will work fine, no warnings. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68084&action=edit Bug 19422: Make sure it will never happen again -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jonathan Druart from comment #4)

Created attachment 68084 [details] [review] Bug 19422: Make sure it will never happen again

This breaks packaging. From the nightly build log at https://apt.abunchofthings.net/koha-nightly/unstable-log.txt read_file '/usr/share/koha/intranet/cgi-bin/installer/data/mysql/kohastructure.sql' - sysopen: No such file or directory at t/check_kohastructure.t line 22. # Looks like your test exited with 2 before it could output anything. t/check_kohastructure.t ............. Dubious, test returned 2 (wstat 512, 0x200) Failed 1/1 subtests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jonathan Druart from comment #7)

Mirko, /usr/share/koha/intranet/cgi-bin/installer/data/mysql/kohastructure.sql does not exist? Where is it then?

This requires a full Koha installation, which is not expected when just building packages. The file is only available in $kohadev/installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19783 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.