[Bug 18087] New: Clarification on File type when using file of biblionumbers to export data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Bug ID: 18087 Summary: Clarification on File type when using file of biblionumbers to export data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: joy@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It is not clear what type of file can be used when uploading a file of biblionumbers in the Export Data screen. Go to Tools->Export Data "Use a file File containing a list of biblio numbers with one biblio number per line. This list works as a filter: it is compatible with other parameters." Change requested: Add details that .csv or .txt file is required. Why: Users attempt to upload .xlsx .pdf or .doc files here. This change will clarify what files can be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|gmcharlt@gmail.com |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 --- Comment #1 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 60094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60094&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60094|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 60105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60105&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- wondering if we should then also have the same for authority records? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60105|0 |1 is obsolete| | --- Comment #4 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 60120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60120&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Hi Claire- I've added the same text to the authority export string. Take a look! Thanks and great suggestions! joy (In reply to Claire Gravely from comment #3)
wondering if we should then also have the same for authority records?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60120|0 |1 is obsolete| | --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 60124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60124&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60177&action=edit Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Joy, I have added a check on the mimetype of the uploaded file, just in case. Can you confirm it works as you would like? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60124|0 |1 is obsolete| | --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 60431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60431&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Joy, only the first patch has been signed off, could you confirm you tested both patches? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60431|0 |1 is obsolete| | --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 60564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60564&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60177|0 |1 is obsolete| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 60567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60567&action=edit Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60564|0 |1 is obsolete| | --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 60568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60568&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- Ah, yes. My error in the git bz attach command. Took two tries, but I think I got it done! Thanks! joy (In reply to Jonathan Druart from comment #10)
Joy, only the first patch has been signed off, could you confirm you tested both patches? :)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why not check the extensions .csv and .txt in javascript when uploading? The mime type check could stay. I guess that application/octet-stream will allow a lot more files that you don't want here. Note that line 77 contains a warning (debug). Please remove it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60567|0 |1 is obsolete| | Attachment #60568|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60643&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60644&action=edit Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Amended patch after signoff: Remove one warn debug line Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60643|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60645&action=edit Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60644|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60646&action=edit Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Amended patch after signoff: Remove one warn debug line Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passed QA under the "Better than before"-pragma. The extension thing is not a blocker and some people want to use files without extension for reasons they should explain themselves :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Joy, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18312 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Introduced bug 18312. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 [Bug 18312] Export is broken unless a file is supplied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 [Bug 18704] File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org