[Bug 8261] New: Cannot search system preferences from Local Use tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Priority: P5 - low Change sponsored?: --- Bug ID: 8261 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Cannot search system preferences from Local Use tab Severity: blocker Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: System Administration Product: Koha Searching the system preferences from the Local Use tab generates a Software error as follows: "Template process failed: file error - .../intranet/htdocs/intranet-tmpl/prog/en/modules/admin/preferences/all.pref: not found at .../lib/C4/Templates.pm line 127." I notice that early versions (such as 3.2) produce search results under an "all preferences" heading. However, I don't see an all.pref file in 3.2 either. The "all preferences" result list seems archaic though, since searching "OPAC" or "MARC" from any other tab provides a much more well formatted list where results are grouped by tab and subheading. Any thoughts on this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|blocker |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bmugambi@gmail.com --- Comment #1 from Marc Véron <veron@veron.ch> --- *** Bug 7522 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- This bug was already reported by Bug 7522. I marked 7522 as duplicate. I can confirm the bug (Version 3.09.00.017 ) Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11880&action=edit Proposed patch Very small patch. systempreferences.tt is using an old include sysprefs-admin-search.inc. New syspref system is using prefs-admin-search.inc include. So this patch sets prefs-admin-search.inc in systempreferences.tt and removes sysprefs-admin-search.inc file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11880|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11884&action=edit Bug 8261: Cannot search system preferences from Local Use tab Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Maybe I have make a mistake but apparently there are 2 pages for manage syspref: admin/systempreferences.pl and admin/preferences.pl. This last one is used. And the corresponding tt files. Let me know if I forgot something, but I am under the impression we can remove the following files: admin/systempreferences.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc And we just replace the l.11 koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc [% IF ( local_use ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/admin/systempreferences.pl">Local use</a></li> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Don't we need systempreferences.pl/.tt for Local use preferences? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #6)
Don't we need systempreferences.pl/.tt for Local use preferences?
Yes :-/ But a big part of systempreferences.pl seems useless. I will open a new Bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- see Bug 8720 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- This one passes QA :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org