[Bug 9072] New: Add sort order option to Linker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Priority: P5 - low Change sponsored?: --- Bug ID: 9072 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Add sort order option to Linker Severity: enhancement Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha When linking biblio to authorities, matching authorities search is made with 'AuthidAsc' sort order hardcoded. This patch allows to set sort order in LinkerOptions syspref (HeadingAsc, HeadingDsc, AuthidAsc or AuthidDsc). Without option, sort order 'AuthidAsc' is used like previsously. This is useful for FirstMatch or LastMatch linkers where results order is important. PS : This solves a problem with some headings. ie : headings "History" and "History of art". The linker search for "History" will return both headings. With linker FistMatch and "HeadingAsc" sort order, the heading "History" will be first and so will match. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13442&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13442|0 |1 is obsolete| | --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Comment on attachment 13442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13442 Proposed patch Forget, patch not work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add sort order option to |Add CheckValidity option to |Linker |Linker -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I changed for a 'CheckValidity' option. When present in LinkerOptions, the authorities found by linker will be checked for validity by comparing a to z subfields values between authority field and biblio field. This is based on C4::Biblio->_check_valid_auth_link behavior. I could not use this method because like said in method comment, this method can not be moved and I could not add a dependency to C4::Biblio in C4::Linker::Default. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13481&action=edit Proposed patch (main) Patch adding CheckValidity option. Small other changes : In C4::AuthoritiesMarc->GetAuthorizedHeading() : a 'k' was missing in a to z list. In C4::Biblio_>_check_valid_auth_link() : I added test of strings used in equal to avoid warning in logs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13482&action=edit Proposed patch (follow-up 1) Follow up patch containing only perltidy formatting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13483&action=edit Proposed patch (follow-up 2) Small additional correction : GetAuthorizedHeading was missing in exported methods of C4::AuthoritiesMarc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #6)
Created attachment 13483 [details] Proposed patch (follow-up 2)
Small additional correction : GetAuthorizedHeading was missing in exported methods of C4::AuthoritiesMarc.
This export was present in Bug 7475 (Teach matching rules to handle authorities) but was removed, certainly unwanted, by Bug 8523 (Display auth hierarchies w/all marcflavours). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13481|0 |1 is obsolete| | Attachment #13482|0 |1 is obsolete| | Attachment #13483|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13487&action=edit Proposed patch (main) I revized patch for performance and for a more clear syntax. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #8)
Created attachment 13487 [details] Proposed patch (main)
I revised patch for performance and for a more clear syntax.
Patch adding CheckValidity option. + Search for linked authorities can return more that 20 results, I set a max of 10000 (in C4::Heading->_search). + In C4::AuthoritiesMarc->GetAuthorizedHeading() : a 'k' was missing in a to z list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13488&action=edit Proposed patch (follow-up 1) Perltidy formatting -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13489&action=edit Proposed patch (follow-up 2) Avoid null for string compare in C4::Biblio::_check_valid_auth_link -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 --- Comment #12 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13490&action=edit Proposed patch (follow-up 3) Missing method export in C4::AuthoritiesMarc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, which is the test plan? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #13)
Hi, which is the test plan?
I agree. Needs a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #15 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Is now invalid -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org