[Bug 34834] New: Add translation context for "Order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Bug ID: 34834 Summary: Add translation context for "Order" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In bug 23983, I added context in acquisitions for "Order" (verb - to order) vs "Order" (noun - an order). Since then, there have been a few additions of "Order" and those don't have the translation context. For example, in fr-CA-staff-prog.po #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt:91 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:349 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:212 #: koha-tmpl/intranet-tmpl/prog/en/includes/str/tinymce_i18n.inc:2 #, c-format msgid "Order" msgstr "Commander" They should have the context Order (verb) #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:212 Order (noun) #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt:91 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:349 ?? (I was not able to find it in the staff interface, but I suspect it's the verb "order" in the sense of "sorting" rather than the acquisition meaning) #: koha-tmpl/intranet-tmpl/prog/en/includes/str/tinymce_i18n.inc:2 To get to each: - orderreceive: when receiving multiple orders, the table heading - parcel: when receiving an order, there is a "View" menu with "Order", "MARC", etc. - z3950_search: when adding an order from an external source, if you hover the mouse on the Order option, there is a thing that opens (a tooltip?) with the word "Order" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 155948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155948&action=edit Bug 34834: Add translation context for "Order" This patch adds context for translation to the term "Order". It is sometimes used as a verb (e.g. to order) and sometimes as a noun (e.g. an order). To test: 1. Go to the various pages and make sure Order appears correctly in English - orderreceive: when receiving multiple orders, the table heading - parcel: when receiving an order, there is a "View" menu with "Order", "MARC", and "Card" - z3950_search: when adding an order from an external source, if you hover the mouse on the Order option, there is a thing that opens (a tooltip?) with the word "Order" 2. Apply patch 3. Redo step 1 in English, make sure the pages still work 4. Update the translation files gulp po:update --lang fr-CA 5. View the messages.po file and make sure the term is translated for both verb and noun context (you can put anything, just something different to tell them apart) 6. View the pages in the other language, the terms should be - orderreceive: noun - parcel: noun - z3950_search: verb -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried using the _p() and __p() syntax in parcel.tt and I can't get it to work. I change the line to either result += '<li><a href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=' + encodeURIComponent(row.order_id) + '" class="previewData">' + _p("noun","Order") + '</a></li>'; or result += '<li><a href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=' + encodeURIComponent(row.order_id) + '" class="previewData">' + __p("noun","Order") + '</a></li>'; and run gulp po:update --lang fr-CA The word is not in either messages.po or messages-js.po What am I doing wrong? In the mean time, I changed the file for Owen's solution of putting the text between the opening and closing tags like <a>text</a> rather than inside the opening tag. This works well, the page loads, the word is in the po files and the translation is applied. The one in parcel.tt is the most annoying one of the three tbh, so I'd really like it to be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds context for release notes| |translators for the word | |Order, as it is sometimes | |used as a verb (e.g. to | |order) and a noun (e.g. an | |order). Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155948|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155955&action=edit Bug 34834: Add translation context for "Order" This patch adds context for translation to the term "Order". It is sometimes used as a verb (e.g. to order) and sometimes as a noun (e.g. an order). To test: 1. Go to the various pages and make sure Order appears correctly in English - orderreceive: when receiving multiple orders, the table heading - parcel: when receiving an order, there is a "View" menu with "Order", "MARC", and "Card" - z3950_search: when adding an order from an external source, if you hover the mouse on the Order option, there is a thing that opens (a tooltip?) with the word "Order" 2. Apply patch 3. Redo step 1 in English, make sure the pages still work 4. Update the translation files gulp po:update --lang fr-CA 5. View the messages.po file and make sure the term is translated for both verb and noun context (you can put anything, just something different to tell them apart) 6. View the pages in the other language, the terms should be - orderreceive: noun - parcel: noun - z3950_search: verb Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155955|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158139&action=edit Bug 34834: Add translation context for "Order" This patch adds context for translation to the term "Order". It is sometimes used as a verb (e.g. to order) and sometimes as a noun (e.g. an order). To test: 1. Go to the various pages and make sure Order appears correctly in English - orderreceive: when receiving multiple orders, the table heading - parcel: when receiving an order, there is a "View" menu with "Order", "MARC", and "Card" - z3950_search: when adding an order from an external source, if you hover the mouse on the Order option, there is a thing that opens (a tooltip?) with the word "Order" 2. Apply patch 3. Redo step 1 in English, make sure the pages still work 4. Update the translation files gulp po:update --lang fr-CA 5. View the messages.po file and make sure the term is translated for both verb and noun context (you can put anything, just something different to tell them apart) 6. View the pages in the other language, the terms should be - orderreceive: noun - parcel: noun - z3950_search: verb Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34834 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org