https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125078&action=edit Bug 29060: Use modal for suspending holds until a date from the holds page This patch modifies the way suspensions are handled when viewing the list of holds on a particular title. In particular, when AutoResumeSuspendedHolds is enabled the "suspend until" form field is hidden until the suspend button is clicked, when a modal window appears. This is consistent with the way it works when working with the list of holds on a patron record. The patch also converts the hold deletion button from an "X" image to a more-standard "Delete" button. To test, apply the patch and make sure AutoResumeSuspendedHolds is enabled. - Locate a title in the catalog with multiple holds. - View the holds on that title. In the list of holds you should see "Delete" and "Suspend" buttons in the last two columns of the tabel of holds. - Test that the "Delete" button works correctly, - Test the "Suspend" button. Clicking it should trigger a modal window where you can set a date for the hold to resume. - Submitting the form with a date should result in the page reloading and showing the hold as suspended until that date. - Submitting hte form without a date should result in the page reloading and showing the hold as suspended. - Test that the "Resume" button works to remove the suspension. - Disable AutoResumeSuspendedHolds. Now when you click the "Suspend" button you should not see the modal. The page should reload and the hold should be suspended without a resume date. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125078|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126446&action=edit Bug 29060: Use modal for suspending holds until a date from the holds page This patch modifies the way suspensions are handled when viewing the list of holds on a particular title. In particular, when AutoResumeSuspendedHolds is enabled the "suspend until" form field is hidden until the suspend button is clicked, when a modal window appears. This is consistent with the way it works when working with the list of holds on a patron record. The patch also converts the hold deletion button from an "X" image to a more-standard "Delete" button. To test, apply the patch and make sure AutoResumeSuspendedHolds is enabled. - Locate a title in the catalog with multiple holds. - View the holds on that title. In the list of holds you should see "Delete" and "Suspend" buttons in the last two columns of the tabel of holds. - Test that the "Delete" button works correctly, - Test the "Suspend" button. Clicking it should trigger a modal window where you can set a date for the hold to resume. - Submitting the form with a date should result in the page reloading and showing the hold as suspended until that date. - Submitting hte form without a date should result in the page reloading and showing the hold as suspended. - Test that the "Resume" button works to remove the suspension. - Disable AutoResumeSuspendedHolds. Now when you click the "Suspend" button you should not see the modal. The page should reload and the hold should be suspended without a resume date. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29060: Use modal for suspending holds until a date from the holds page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Please look at changes from Bug 29737 "Fix suspend from hold list" -- You are receiving this mail because: You are watching all bug changes.