[Bug 16438] New: Use Font Awesome icons in batch record deletion table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Bug ID: 16438 Summary: Use Font Awesome icons in batch record deletion table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx@gmail.com Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Add Font Awesome icons in table for tables in authorities and bib records in batch record deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51169&action=edit Bug 16438: Use Font Awesome icons in batch record deletion table Add Font Awesome icons in table for tables in authorities and bib records in batch record deletion To test: 1- Go to Tools > Batch record deletion 2- Try to delete bib and authorities records 3- Look the table presented 4- Apply patch and repeat steps 1 to 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51169|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51170&action=edit Bug 16438: Use Font Awesome icons in batch templates Add Font Awesome icons in tables in authorities and bib records in batch item/record deletion, modification templates To test: 1- Go to Tools > Batch item/record deletion/modification 2- Try to delete/modify itmes/bib and authorities records 3- Look all tables presented and notice about the new icons in Select all Clear all, etc. 4- Apply patch and repeat step 1 to 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use Font Awesome icons in |Use Font Awesome icons in |batch record deletion table |batch templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51170|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51171&action=edit [SIGNED-OFF] Bug 16438: Use Font Awesome icons in batch templates Add Font Awesome icons in tables in authorities and bib records in batch item/record deletion, modification templates To test: 1- Go to Tools > Batch item/record deletion/modification 2- Try to delete/modify itmes/bib and authorities records 3- Look all tables presented and notice about the new icons in Select all Clear all, etc. 4- Apply patch and repeat step 1 to 3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work, nice view. No Errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I would prefer that we use no icon if there is no single icon which works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51210&action=edit Bug 16438: (followup) change icons to one icon Change the two icons to just one: "fa fa-minus-square" To test: follow the previous commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51210|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51211&action=edit Bug 16438: (followup) change icons to one icon Change the two icons to just one: "fa fa-minus-square" To test: follow the previous commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Owen and Jonathan Please look if this is Ok Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- My vote is still for no icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Owen Leonard from comment #8)
My vote is still for no icon.
For all options or just for those icons which don't work well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51211|0 |1 is obsolete| | --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51212&action=edit Bug 16438: (followup) remove item where no single icon exist for options Remove the double icon in options where double icons don't work well To test: follow the previous commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Owen I've deleted the icons for options where icon doesn't fit well with description. Feel free to change and/or close the bug if you think this isn't the right way. No biggie. Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51212|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51213&action=edit [SIGNED-OFF] Bug 16438: (followup) remove item where no single icon exist for options Remove the double icon in options where double icons don't work well To test: follow the previous commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51171|0 |1 is obsolete| | Attachment #51213|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51214&action=edit Bug 16438: Use Font Awesome icons in batch templates Add Font Awesome icons in tables in authorities and bib records in batch item/record deletion, modification templates To test: 1- Go to Tools > Batch item/record deletion/modification 2- Try to delete/modify itmes/bib and authorities records 3- Look all tables presented and notice about the new icons in Select all Clear all, etc. 4- Apply patch and repeat step 1 to 3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work, nice view. No Errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51215&action=edit Bug 16438: (followup) remove item where no single icon exist for options Remove the double icon in options where double icons don't work well To test: follow the previous commit Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #15 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org