[Bug 12690] New: opacuserjs gets loaded twice in self checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 Bug ID: 12690 Summary: opacuserjs gets loaded twice in self checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Currently, we're loading "opacuserjs" in sco-main.tt twice. Once at the very bottom at the template, and once via opac-bottom.inc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opacuserjs gets loaded |opacuserjs gets loaded |twice in self checkout |twice in self checkout && | |change syspref calls -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opacuserjs gets loaded |opacuserjs gets loaded |twice in self checkout && |twice in self checkout |change syspref calls | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 30441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30441&action=edit Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 30444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30444&action=edit [Signed-off] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30441|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30501&action=edit [PASSED QA] Bug 12690 - opacuserjs gets loaded twice in self checkout This patch removes a second instance of "opacuserjs" in the opac self-checkout. _TEST PLAN_ 1) Enable OPAC Self-checkout in the system preferences 2) Type the following code into your "opacuserjs" system preference: alert("This is a test"); 2) Visit /cgi-bin/koha/sco/sco-main.pl 3) Note that you get a pop-up saying "This is a test" twice. 4) Apply the patch 5) Refresh /cgi-bin/koha/sco/sco-main.pl 6) Note that you now only get a pop-up saying "This is a test" once. Followed test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> opac-bottom.inc already adds opacuserjs, so the additional line in this template can be removed. Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org