[Bug 15785] New: Use Font Awesome icons in confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Bug ID: 15785 Summary: Use Font Awesome icons in confirmation dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 47863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47863&action=edit Screenshot showing the kind of dialog to be modified Some (non-JavaScript) dialogs in Koha show a pair of Yes/No buttons styled with "approve"/"deny" classes which use image files for the icon. These could instead be styled using Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 47929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47929&action=edit Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47929|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47930&action=edit [SIGNED-OFF]Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Icons changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 [Bug 15790] Don't delete a MARC framework if existing records use that framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15804 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 47932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47932&action=edit Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Icons changed Signed-off-by: Marc Véron <veron@veron.ch> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15804 [Bug 15804] Use standard dialog style for confirmation of MARC subfield deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #47932|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Comment on attachment 47932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47932 Bug 15785 - Use Font Awesome icons in confirmation dialogs Hector was faster :-) Obsoleting my sign-off patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47930|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47971&action=edit Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Icons changed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have fixed the conflicts with the revert of bug 13618 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 [Bug 15784] Library deletion warning is incorrectly styled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47971|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47983&action=edit Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi someone attach a wrong bug number in this patch, please revert/obsolete the last patch attached -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47971|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #8)
Hi someone attach a wrong bug number in this patch, please revert/obsolete the last patch attached
Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15826 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15826 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15826 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 [Bug 15858] Use Font Awesome icons in dialog alert for addorder.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15884 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the may 2016 release. Thanks Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15884 [Bug 15884] Vendor contract deletion warning is incorrectly styled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950 [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 [Bug 15959] Use Font Awesome icons for attach item confirmations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15960 Blocks| |15961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15960 [Bug 15960] Use Font Awesome icons for classification filing rule deletion error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 [Bug 15961] Use Font Awesome icons for confirmation of currency deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 [Bug 15978] Use Font Awesome icons for guided reports error dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15980 Blocks| |15983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15980 [Bug 15980] Use Font Awesome icons in subscription frequency deletion confirmation dialog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org