[Bug 23077] New: Can't import patrons without cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Bug ID: 23077 Summary: Can't import patrons without cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Note the plural, you can import 1 patron without a cardnumber, it defaults to an empty string The next patron cannot be imported because empty string is already in use Will attach sample file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14601 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90415&action=edit Bug 23077 - Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90416&action=edit Bug 23077 - Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90417&action=edit Sample import file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90418&action=edit Sample file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19012 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 90474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90474&action=edit [SIGNED-OFF] Bug 23077 - Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 90475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90475&action=edit [SIGNED-OFF] Bug 23077 - Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Attachment #90415|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- QA tool is not happy: OK Koha/Patrons/Import.pm FAIL t/db_dependent/Koha/Patrons/Import.t FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 400) Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 033eec3a20 * Commit title does not start with 'Bug XXXXX: ' - 79dd7b20d2 And the patch introduces a minor behaviour change: on master I can import a patron with cardnumber '0', with the patch I can't -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90474|0 |1 is obsolete| | Attachment #90475|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91181&action=edit Bug 23077: Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91182&action=edit Bug 23077: Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91183&action=edit Bug 23077: Fix import of cardnumber 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91181|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91315&action=edit Bug 23077: Unit tests prove -v t/db_dependent/Koha/Patrons/Import.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91182|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91316&action=edit Bug 23077: Don't fill cardnumber with empty string To test: 1 - Apply unit test patch only 2 - prove the tests, they fail 3 - Attempt to import the attached sample file 4 - First patron may be imported, second will give error (or both will error) 5 - If only one error, import agian, now both have error 6 - Apply this patch 7 - Prove tests, they pass! 8 - Import the sample file 9 - It succeeds! Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91183|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 91317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91317&action=edit Bug 23077: Fix import of cardnumber 0 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle@bywatersolutions.c | |om --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 14601 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org