[Bug 31863] New: Advanced cataloging editor no longer auto-resizes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Bug ID: 31863 Summary: Advanced cataloging editor no longer auto-resizes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The advanced cataloging editor no longer automatically resizes the height of the CodeMirror editor, prior to 22.05 it did. To recreate: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Prior to 22.05 it would dynamically adjust to the height of your screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com, | |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- This is because of how we calculate the adjusted height in the function 'onResize'. If the 'changelanguage' element does not exist then '$('#changelanguage').height()' will be undefined. 1 + undefined == NaN. We cannot change the editor height to NaN. We should check for the existence of the 'changelanguage' and if it is not present change the calculation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142101&action=edit Bug 31863: Account for changelanguage element when adjusting editor height To test: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Resize your screen, nothing happens to the editor height 5. Apply patch 6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. 7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. 8. Make sure the editor height is still being properly set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142101|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 142112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142112&action=edit Bug 31863: Account for changelanguage element when adjusting editor height To test: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Resize your screen, nothing happens to the editor height 5. Apply patch 6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. 7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. 8. Make sure the editor height is still being properly set. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Lucas! I had noticed yesterday when testing another bug, but hadn't yet logged a bug. After installing a language, I noticed that the titles for records aren't displayed in the search results after switching to the language in the staff interface and OPAC (even after a reindex). I'm sure it hasn't done that in the past... so maybe another staff interface bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #4)
Thanks Lucas! I had noticed yesterday when testing another bug, but hadn't yet logged a bug.
After installing a language, I noticed that the titles for records aren't displayed in the search results after switching to the language in the staff interface and OPAC (even after a reindex).
I'm sure it hasn't done that in the past... so maybe another staff interface bug?
Hey David, Thanks for testing. I am unable to reproduce this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #5)
(In reply to David Nind from comment #4)
Thanks Lucas! I had noticed yesterday when testing another bug, but hadn't yet logged a bug.
After installing a language, I noticed that the titles for records aren't displayed in the search results after switching to the language in the staff interface and OPAC (even after a reindex).
I'm sure it hasn't done that in the past... so maybe another staff interface bug?
Hey David,
Thanks for testing. I am unable to reproduce this problem.
Katrin said on IRC that this sometimes happens with translations (was for fr-CA), so is not a staff interface related bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142112|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142411&action=edit Bug 31863: Account for changelanguage element when adjusting editor height To test: 1. Turn on 'EnableAdvancedCatalogingEditor' 2. Go to a record with enough MARC data that it should take up the entire width of your screen, 3. The CodeMirror editor will only be 300px. 4. Resize your screen, nothing happens to the editor height 5. Apply patch 6. Look at the same record in your editor, the editor should go to the bottom of the page now. Resizing your screen should resize the editor. 7. Have some additional language packs installed, and change the language system pref so the '#changelanguage' option will appear. 8. Make sure the editor height is still being properly set. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253 [Bug 32253] Advanced cataloging editor doesn't load every line initially -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org