http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- This may be version specific. I could not replicate this in 3.21. Christopher --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- This may be version specific. I could not replicate this in 3.21. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41431&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41432&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41432|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41433&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #8 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41458&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41648&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.