[Bug 36844] New: Set library, desk, and cash register menu follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Bug ID: 36844 Summary: Set library, desk, and cash register menu follow-ups Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Keywords: rel_24_05_candidate Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 36582 - On the login form, the form field IDs need to be updated to match the changed form fields in set-library.tt. Inclusion of desk_selection.js and register_selection.js need to be removed. - On the cash register statistics page, the form needs specific JS to deal with just the library-cash register selection changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 [Bug 36582] Add option to set library, desk, and register from user menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166651&action=edit Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166651|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166657&action=edit Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166657|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 166662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166662&action=edit Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- For the cash register statistics report, if there are no cash register for a library, I'm assuming that displaying --All-- is OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166662|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 166665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166665&action=edit Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 166666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166666&action=edit Bug 36844: (QA follow-up): fix forgotten 'for' attr change It didn't match the <select> id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166665|0 |1 is obsolete| | Attachment #166666|0 |1 is obsolete| | --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166770&action=edit Bug 36844: Set library, desk, and cash register menu follow-ups This patch ties up a couple of loose ends which should have been included in Bug 36582. The patch includes fixes for the staff interface login page and the cash register statistics page. To test you should have multiple libraries, desks, and cash registers defined. You may need to enable the UseCirculationDesks and UseCashRegisters system preferences. - Apply the patch and log out of the staff interface. - On the login form, test that changing your selected library correctly affects the desk and cash register dropdowns: Only desks and registers for your selected library should appear. - Log in and confirm that your selections were submitted correctly. - Go to Reports, and under "Statistics wizards" choose "Cash register." - Confirm that changes to the "Transaction library" correctly change the available options in the "Cash register" dropdown, including the "All" option. Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166771&action=edit Bug 36844: (QA follow-up): fix forgotten 'for' attr change It didn't match the <select> id. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166772&action=edit Bug 36844: (QA follow-up) Fix preselected options on set-library.pl I found that when switching from a branch with a default register to one without, the default register for the last branch was remaining selected (though disabled) When opening the page if no desk was set (choose 'My library' on initial login) the branch was default to 'No desk' rather than defaulting to the first desk of the current branch Remove a debugging line as well Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36582 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |nick@bywatersolutions.com |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36844 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org