http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35326&action=edit Bug 13590 - Add ability to charge fines at start of charge period -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35327|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35328&action=edit Bug 13590 - Add ability to charge fines at start of charge period -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35329|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35330&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Grace period behavior remains unchanged, but this patch should allow you to get the behavior you are looking for. (In reply to Katrin Fischer from comment #6)

Hi Kyle,

this sounds very interesting - how is the grace period treated?

Currently we have something like, if the grace period is < the charging interval, it won't have any effect, but only if it's > (iirc).

We have libraries that would like something like: due date 2 days grace period 1st fine 7 days interval 2nd fine 7 days interval 3rd fine

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia@hotmail.com --- Comment #11 from Aleisha Amohia <aleishaamohia@hotmail.com> --- When running updatedatabase.pl - Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at updatedatabase.pl line 37. BEGIN failed--compilation aborted at updatedatabase.pl line 37. Hoping this wasn't just me testing this wrong, setting as Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37909|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38732&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Mirko Tietgen from comment #14)

(In reply to Kyle M Hall from comment #13)

...

3) prove t/db_dependent/Circulation_Issuingrule.t

t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.06 usr 0.02 sys + 1.98 cusr 0.23 csys = 2.29 CPU) Result: PASS

...

4) prove t/db_dependent/Circulation.t

t/db_dependent/Circulation.t .. 22/61 DBD::mysql::st execute failed: Duplicate entry '4' for key 'PRIMARY' at /home/mirko/koha/C4/Circulation.pm line 2100. DBD::mysql::st execute failed: Duplicate entry '4' for key 'PRIMARY' at /home/mirko/koha/C4/Circulation.pm line 2100. # Looks like you planned 61 tests but ran 43. # Looks like your test exited with 255 just after 43. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 18/61 subtests

Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 43 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 61 tests but ran 43. Files=1, Tests=43, 5 wallclock secs ( 0.07 usr 0.03 sys + 3.02 cusr 0.40 csys = 3.52 CPU) Result: FAIL

...

5) prove t/db_dependent/Fines.t

t/db_dependent/Fines.t .. DBIx::Class::ResultSet::create(): No such column chargeperiod_charge_at on Koha::Schema::Result::Issuingrule at t/db_dependent/Fines.t line 21 # Looks like your test exited with 255 before it could output anything. t/db_dependent/Fines.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/5 subtests

Test Summary Report ------------------- t/db_dependent/Fines.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 0. Files=1, Tests=0, 3 wallclock secs ( 0.05 usr 0.03 sys + 1.84 cusr 0.23 csys = 2.15 CPU) Result: FAIL

I ran updatedatabase before I tested, so I wonder if something is missing?

Did you run the unit tests with a fresh install of Koha with the default data? Kyle -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41149|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41150&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590

Nicole C. Engard <nengard@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard@gmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #20 from Nicole C. Engard <nengard@gmail.com> ---
11:48 ~/kohaclone (master % u=)$ git qa 13590
>From git://git.koha-community.org/koha
 * branch            master     -> FETCH_HEAD
Branch bug13590-qa set up to track remote branch master from origin.
Switched to a new branch 'bug13590-qa'
Bug 13590 - Add ability to charge fines at start of charge period

41151 - Bug 13590 - Add ability to charge fines at start of charge period

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 13590 - Add ability to charge fines at start of charge period
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Circulation_Issuingrule.t
CONFLICT (content): Merge conflict in t/db_dependent/Circulation_Issuingrule.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging admin/smart-rules.pl
CONFLICT (content): Merge conflict in admin/smart-rules.pl
Auto-merging Koha/Schema/Result/Issuingrule.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 13590 - Add ability to charge fines at start of charge
period
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-13590---Add-ability-to-charge-fines-at-start-o-yKwpQy.patch
11:48 ~/kohaclone (bug13590-qa *+%|AM u=)$

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41151|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43406&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #22 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 43407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43407&action=edit [SIGNED-OFF] Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules Signed-off-by: Daniel Grobani <dgrobani@samuelmerritt.edu> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43406|0 |1 is obsolete| | Attachment #43407|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43424&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules Signed-off-by: Daniel Grobani <dgrobani@samuelmerritt.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 for QA Jonathan - this was/is a wish list item for us! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.