[Bug 15600] New: System preferences broken toolbar looks broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Bug ID: 15600 Summary: System preferences broken toolbar looks broken Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/preferences.pl OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 46896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46896&action=edit Broken appearance of the toolbar In system preferences, when you scroll down a long page the toolbar with the "save" button "sticks" to the top of the browser window so that the button is always accessible. Since the addition of the professional cataloging interface (Bug 11559) the appearance of this toolbar has been broken (improper passing, transparent background). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 46897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46897&action=edit Correct appearance of the toolbar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster@gmail.com --- Comment #2 from Chloe Alabaster <chloealabaster@gmail.com> --- Created attachment 46952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46952&action=edit This is what I have done so far with the toolbar I changed the color of the tool bar so that it was no longer "transparent" however now from this you cant tell that the "submit" button is a button. Will start working on a way to make this noticeable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |chloealabaster@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #3 from Chloe Alabaster <chloealabaster@gmail.com> --- Created attachment 46960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46960&action=edit when testing it should look like this: this what the tool bar should look like with this patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #4 from Chloe Alabaster <chloealabaster@gmail.com> --- Created attachment 46961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46961&action=edit when testing the hover: in addition to the screen shot above; when hovering over it should look like this -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #5 from Chloe Alabaster <chloealabaster@gmail.com> --- Created attachment 46962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46962&action=edit Bug 15600 - System preferences broken toolbar looks broken To test: 1-see without patch the toolbar looks transparent and "broken" 2-apply patch, with this the toolbar is solid and has new colours (including the hover) -see screenshots for examples 3-try scrolling on different tabs to the left eg "OPAC" and that the style continues with them -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Hi Chloe, the patch works for me. But I think the nondescript look of the button is intended. What you could try: before applying your patch, open a part of the system preferences that needs scrolling to see all parameters. Scroll down a bit so you get the toolbar. The button is not very impressive. Then go into one of the parameter fields and change it. The button changes the layout now and looks more button-like, because there are changes to save. Do you see what I mean? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think the correct solution is to look at the commit that created the bug and see what changes were the cause: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=edd64d30188fef2b... The problem stems from the fact that Bug 11559 made changes to staff-global.css in a way that didn't take into account the toolbar in system preferences. http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/intr... As far as I can tell based on my test the deletions from staff-global.css made by that commit can be reversed while keeping the additions. I'm going to try to ask pianohacker if he knows of a reason not to do that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org