https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Dragging and dropping |Dragging and dropping |subfield of repided tags |subfield of repeated tags |doesn't work. |doesn't work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 159196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159196&action=edit Bug 35383: Make subfields of repeated tags draggable To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Repeat any tag that may be repeated and has more than one subfield (e.g. 050 or 082) (click "Repeat this tag") 3. Try dragging a subfield of the new repeated tag Apply the patch and make sure dragging a subfield works well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks for your patch, Slava. My only concern would be the assumption that Sortable is defined. In the current codebase this seems to be the case (called from authorities.tt or addbiblio). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #5 from Slava Shishkin <slavashishkin@gmail.com> --- (In reply to Marcel de Rooy from comment #4) thanks, that makes a sense, I can wrap up it in "if", if (typeof Sortable !== 'undefined') { $(clone).find("ul.sortable_subfield").each((i, e) => { Sortable.create(e, { animation: 150, }); }); } but the best then is to make a callback option for CloneSubfield and leave Sortable.create code in files where it resides, but that also leads to refactoring of onclick="CloneSubfield... to modern way how we doing that in our codebase by moving that listener to JS document ready block Marcel, what do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Slava Shishkin from comment #5)

(In reply to Marcel de Rooy from comment #4)

thanks, that makes a sense,

I can wrap up it in "if",

if (typeof Sortable !== 'undefined') { $(clone).find("ul.sortable_subfield").each((i, e) => { Sortable.create(e, { animation: 150, }); }); }

but the best then is to make a callback option for CloneSubfield and leave Sortable.create code in files where it resides,

but that also leads to refactoring of onclick="CloneSubfield... to modern way how we doing that in our codebase by moving that listener to JS document ready block

Marcel, what do you think?

You are welcome to improve it. Please do so on a new report. I think that this patch can go in now in its current form. Your commitment is appreciated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36388 -- You are receiving this mail because: You are watching all bug changes.