https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171132&action=edit Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171132|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 171135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171135&action=edit Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171135|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172268&action=edit Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37848 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are watching all bug changes.